Use Git submodule for Hive Thrift API #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than static/hms.thrift, use a git submodule to reference Trino's [Hive Metastore Thrift repo](https://github.com/trinodb/hive-thrift). I chose this one over [Hive's official repo](https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift) because the submodule checks out the entire repo, which is slow for Hive. The `hms` package has been renamed to `hive_metastore` as well. I think this is preferable anyway since it's more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than static/hms.thrift, use a git submodule to reference Trino's Hive Metastore Thrift repo. I chose this one over
Hive's official repo because the submodule checks out the entire repo, which is slow for Hive.
The
hmspackage has been renamed tohive_metastoreas well. I think this is preferable anyway since it's more explicit.