Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Git submodule for Hive Thrift API #5

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Use Git submodule for Hive Thrift API #5

merged 1 commit into from
Jun 22, 2023

Commits on Jun 22, 2023

  1. Use Git submodule for Hive Thrift API 

    Rather than static/hms.thrift, use a git submodule to reference Trino's
[Hive Metastore Thrift repo](https://github.com/trinodb/hive-thrift). I chose
this one over
[Hive's official repo](https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift)
because the submodule checks out the entire repo, which is slow for Hive.

The `hms` package has been renamed to `hive_metastore` as well. I think this is
preferable anyway since it's more explicit.
    @criccomini
    criccomini committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    5a73a53 View commit details
    Browse the repository at this point in the history