Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import cycle not allowed for resolvers/referencers #1042

Closed
haarchri opened this issue Dec 31, 2021 · 5 comments
Closed

import cycle not allowed for resolvers/referencers #1042

haarchri opened this issue Dec 31, 2021 · 5 comments
Labels
bug Something isn't working stale

Comments

@haarchri
Copy link
Member

haarchri commented Dec 31, 2021

What happened?

since we have more and more resources in provider-aws we see go import cycle issues for resolvers/referencers:

Bildschirmfoto 2021-12-31 um 10 44 45

How can we reproduce it?

What environment did it happen in?

Crossplane version:

@haarchri haarchri added the bug Something isn't working label Dec 31, 2021
@muvaf
Copy link
Member

muvaf commented Jan 5, 2022

One way could be to use unstructured.Unstructured in your own custom resolver. Though it'd be nice if we have that in crossplane-runtime similar to the existing strong-typed resolver.

@haarchri
Copy link
Member Author

haarchri commented Jan 6, 2022

@muvaf can you provide one example ?

@muvaf
Copy link
Member

muvaf commented Jan 31, 2022

@haarchri I don't have a concrete example right now. Opened crossplane/crossplane-runtime#313 with a bit more details.

@github-actions
Copy link

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Sep 11, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2023
@josegonzalez
Copy link

It would be great to re-open this. Currently there isn't a way to create/update a Launch Template and reference it when creating an ASG, meaning there is extra manual work if your Launch Template ever changes version (which is kinda the whole point of the thing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

3 participants