Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added s3 resolvers for queueArn, replicaKmsKeyId, kmsMasterKeyId, crossplane:generate:reference #1022

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Dec 18, 2021

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

  • added queueArnRef, queueArnSelector
  • added replicaKmsKeyIdRef, replicaKmsKeyIdSelector
  • added kmsMasterKeyIdRef, kmsMasterKeyIdSelector
  • changed for s3 all resources from referencers.go to zz_generated.resolvers.go with crossplane:generate:reference
  • moved SNSTopicARN() to notification referencers.go - to have in more generic

side note

  • LambdaFunctionArn for resolvers is not possible because of -: import cycle not allowed: s3 -> lambda / lambda

Fixes #556 #640

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • created s3 bucket with a lot of configurations

…lvers

Signed-off-by: haarchri <chhaar30@googlemail.com>
@haarchri haarchri merged commit 96a15aa into crossplane-contrib:master Jan 12, 2022
@haarchri haarchri deleted the feature/s3-resolvers branch January 12, 2022 16:56
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add SQS ARN selector for S3 notificationConfiguration
2 participants