Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iam-oidc-provider): add reference to eks-cluster #830

Closed
wants to merge 1 commit into from

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Sep 13, 2021

Signed-off-by: Christopher Haar chhaar30@googlemail.com

Description of your changes

Fixes #796

Name:         some-provider
Namespace:    
Labels:       <none>
Annotations:  crossplane.io/external-name: arn:aws:iam::255932642XXX:oidc-provider/oidc.eks.eu-central-1.amazonaws.com/id/D6EC1A935D48FE05331D87D12DF8A123
API Version:  iam.aws.crossplane.io/v1beta1
Kind:         OpenIDConnectProvider
Metadata:
  Creation Timestamp:  2022-01-03T07:44:25Z
  Finalizers:
    finalizer.managedresource.crossplane.io
  Generation:        2
  Resource Version:  2909791
  Self Link:         /apis/identity.aws.crossplane.io/v1alpha1/openidconnectproviders/some-provider
  UID:               0429aaff-8c4d-4e6a-92a1-37a2e8de2f90
Spec:
  Deletion Policy:  Delete
  For Provider:
    Client ID List:
      sts.amazonaws.com
    Eks URL Ref:
      Name:  sample-cluster
    Thumbprint List:
      9e99a48a9960b14926bb7f3b02e22da2b0ab7280
    URL:  https://oidc.eks.eu-central-1.amazonaws.com/id/D6EC1A935D48FE05331D87D12DF8A123
  Provider Config Ref:
    Name:  example

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • create eks controlplane
  • create openidconnectprovider with eksUrlRef

Copy link
Collaborator

@AaronME AaronME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @haarchri !

(Let me know if you want to handle the rebase/merge or I can do it later today)

@AaronME AaronME self-requested a review January 3, 2022 17:37
@haarchri
Copy link
Member Author

haarchri commented Jan 3, 2022

@AaronME thanks for Review i can handle the rebase

@haarchri
Copy link
Member Author

haarchri commented Jan 3, 2022

rebased but in general we have here the same issue: - go import cycle not allowed - think we need an better approach for cross referencing before we can merge here #1042

Signed-off-by: haarchri <chhaar30@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to create IAM OIDC provider for an EKS cluster automatically
2 participants