Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2/securitygroup)!: Make region a required field #2003

Merged
merged 1 commit into from
Mar 19, 2024
Merged

feat(ec2/securitygroup)!: Make region a required field #2003

merged 1 commit into from
Mar 19, 2024

Conversation

haooliveira84
Copy link
Contributor

Description of your changes

Fixes #2002

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@haooliveira84 haooliveira84 changed the title [ec2] add missing required tag in SecurityGroup Region chore(ec2): add missing required tag in SecurityGroup Region Feb 15, 2024
@haooliveira84
Copy link
Contributor Author

/test-examples

@MisterMX
Copy link
Collaborator

@haooliveira84 can you rebase on the latest master to fix e2e tests?

@MisterMX
Copy link
Collaborator

@haooliveira84 can you squash your changes into a single commit and sign it?

@haooliveira84
Copy link
Contributor Author

@haooliveira84 can you squash your changes into a single commit and sign it?

Done @MisterMX

@MisterMX
Copy link
Collaborator

It looks like something has gone wrong and a bunch of other changes has been included as well. @haooliveira84 can you check again?

@haooliveira84
Copy link
Contributor Author

It looks like something has gone wrong and a bunch of other changes has been included as well. @haooliveira84 can you check again?

Done @MisterMX

@MisterMX MisterMX force-pushed the sq-region branch 2 times, most recently from 481606c to e3d843c Compare March 18, 2024 10:08
MisterMX
MisterMX requested changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch still contained a bunch of other commits. Probably because of the merge from master (better use rebase for that). I took the liberty to rebase the branch on the latest master and squash it into a single commit.

While doing that I noticed one thing that needs to be fixed before merge.

apis/ec2/v1beta1/securitygroup_types.go Outdated Show resolved Hide resolved
@MisterMX MisterMX changed the title chore(ec2): add missing required tag in SecurityGroup Region feat(ec2/securitygroup)!: Make region a required field Mar 18, 2024
@MisterMX MisterMX force-pushed the sq-region branch 2 times, most recently from 9b5c908 to 8d66ef4 Compare March 18, 2024 10:10
MisterMX
MisterMX approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @haooliveira84!

@haooliveira84 @MisterMX
feat(ec2/securitygroup)!: Make region a required field
c207bbf 
Signed-off-by: Henrique Oliveira <henrique.antonio@grupoboticario.com.br>
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
Signed-off-by: Henrique Oliveira <henrique.antonio@grupoboticario.com.br>
@MisterMX MisterMX merged commit 432daeb into crossplane-contrib:master Mar 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisterMX MisterMX MisterMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[documentation] Missing required tag in SecurityGrou region parameter
2 participants
@haooliveira84 @MisterMX