-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick: Allow creation of TCP groups where an op has multiple uses #76
Cherry pick: Allow creation of TCP groups where an op has multiple uses #76
Commits on Oct 27, 2023
-
Apply Cruise Internal Patches (cruise-automation#1)
As titled. Here's the corresponding torch-mlir PR: https://github.robot.car/cruise/mla-robocomp-torch-mlir/pull/156. Upstream cleanup was done via these PRs: - [x] [cruise-automation/pull/12](cruise-automation#12) - [x] [cruise-automation/pull/13](cruise-automation#13) - [x] [cruise-automation/pull/14](cruise-automation#14)
Configuration menu - View commit details
-
Copy full SHA for ccaa542 - Browse repository at this point
Copy the full SHA ccaa542View commit details
Commits on Oct 31, 2023
-
Conversion for
aten.index.Tensor_hacked_twin
->tcp.custom_op
(cr……uise-automation#3) This is useful for ML ranker C7: ``` ERROR: [RoboCompiler] - RoboCompiler step 'RoboCompiler Optimize' failed with the following error: cruise/mlp/robotorch/project/trajectory_ranking/model_architectures/per_npc_ranker.py:712:0: error: failed to legalize operation 'torch.aten.index.Tensor_hacked_twin' that was explicitly marked illegal ``` TorchToTosa doesn't match the AtenIndexTensorHackedTwinOp due to [this](https://sourcegraph.robot.car/github.robot.car/cruise/mla-robocomp-torch-mlir/-/blob/lib/Conversion/TorchToTosa/TorchToTosa.cpp?L3788) constraint: ``` // Right now only support multiple indexes with same shape // TODO for different shape multiple indexes, add broadcast_to for small // shape for (auto indexShapeOneDim : indexesShape) { if (!llvm::equal(indexesShape[0], indexShapeOneDim)) { return rewriter.notifyMatchFailure( op, "unimplemented: Only support multi indexes with same shape"); } } ``` where we see multiple index tensors of different shapes: ``` %278 = torch.prim.ListConstruct %277, %273, %270, %205 : (!torch.vtensor<[1,1,1,1],si64>, !torch.vtensor<[24,1,1],si64>, !torch.vtensor<[2,1],si64>, !torch.vtensor<[40],si64>) -> !torch.list<vtensor> %279 = torch.aten.index.Tensor_hacked_twin %arg9, %278 : !torch.vtensor<[1,24,2,40],f32>, !torch.list<vtensor> -> !torch.vtensor<[1,24,2,40],f32> ``` We can dig into supporting this case in TorchToTosa eventually, however this is to unblock the immediate case for C7 where we plan to map this to a data movement kernel (like gather).
Configuration menu - View commit details
-
Copy full SHA for 7547c93 - Browse repository at this point
Copy the full SHA 7547c93View commit details
Commits on Nov 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 04b9d8c - Browse repository at this point
Copy the full SHA 04b9d8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2811d4 - Browse repository at this point
Copy the full SHA b2811d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for aba958a - Browse repository at this point
Copy the full SHA aba958aView commit details
Commits on Nov 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b0add85 - Browse repository at this point
Copy the full SHA b0add85View commit details
Commits on Nov 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fc9d25c - Browse repository at this point
Copy the full SHA fc9d25cView commit details
Commits on Nov 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 80bba2e - Browse repository at this point
Copy the full SHA 80bba2eView commit details -
Converting index_put op to a custom op (cruise-automation#5)
Merge cruise-automation#21 from upstream.
Configuration menu - View commit details
-
Copy full SHA for 052ba71 - Browse repository at this point
Copy the full SHA 052ba71View commit details
Commits on Dec 7, 2023
-
Move bottom up fuser declaration to header file (cruise-automation#23)
Move bottom up fuser declaration to header file No testing required since it's a minor restructuring --------- Co-authored-by: Muhammad Abubakar <muhammad.abubakar@getcruise.com>
Configuration menu - View commit details
-
Copy full SHA for eea9c34 - Browse repository at this point
Copy the full SHA eea9c34View commit details -
[Cherry-Pick] Move bottom up fuser declaration to header file (cruise…
…-automation#7) Move bottom up fuser declaration to header file No testing required since it's a minor restructuring Cherry-pick from cruise-automation@c4c94fb --------- Co-authored-by: Muhammad Abubakar <muhammad.abubakar@getcruise.com>
Muhammad Abubakar authored and GitHub Enterprise committedDec 7, 2023 Configuration menu - View commit details
-
Copy full SHA for 9c19ae3 - Browse repository at this point
Copy the full SHA 9c19ae3View commit details
Commits on Dec 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fe8bacd - Browse repository at this point
Copy the full SHA fe8bacdView commit details -
TCP Upgrade (cruise-automation#8)
Bumps TCP to `c4c94fb25f2c3470839796025f40f0487b3b69b6`.
Configuration menu - View commit details
-
Copy full SHA for aec758d - Browse repository at this point
Copy the full SHA aec758dView commit details
Commits on Jan 16, 2024
-
Lower torch transposed convolution to a custom TCP op (cruise-automat…
…ion#25) As titled, lower torch transposed convolution to a custom TCP op to avoid a mis-compilation in `TorchToTosa`. --------- Co-authored-by: Srinath Avadhanula <srinath.avadhanula@getcruise.com>
Configuration menu - View commit details
-
Copy full SHA for fdf0338 - Browse repository at this point
Copy the full SHA fdf0338View commit details -
Cherry pick: Lower torch transposed convolution to a custom TCP op (c…
…ruise-automation#25) (cruise-automation#10) As titled, lower torch transposed convolution to a custom TCP op to avoid a mis-compilation in `TorchToTosa`. Cherry-pick from upstream: cruise-automation#25 --------- Co-authored-by: Srinath Avadhanula <srinath.avadhanula@getcruise.com>
Srinath Avadhanula authored and GitHub Enterprise committedJan 16, 2024 Configuration menu - View commit details
-
Copy full SHA for bf6191f - Browse repository at this point
Copy the full SHA bf6191fView commit details
Commits on Jan 17, 2024
-
Merge branch 'main' into aaron.stgeorge/upgrade_01_24
aaron-stgeorge committedJan 17, 2024 Configuration menu - View commit details
-
Copy full SHA for 33846e9 - Browse repository at this point
Copy the full SHA 33846e9View commit details
Commits on Jan 22, 2024
-
Add TCP custom op builder helper (cruise-automation#33)
Add a utility to aid in converting torch ops to `tcp.custom_op` --------- Co-authored-by: Srinath Avadhanula <srinath.avadhanula@getcruise.com>
Configuration menu - View commit details
-
Copy full SHA for 4e1d4c9 - Browse repository at this point
Copy the full SHA 4e1d4c9View commit details
Commits on Jan 23, 2024
-
Cherry-pick: Add TCP custom op builder helper (cruise-automation#33) (c…
…ruise-automation#12) Add a utility to aid in converting torch ops to `tcp.custom_op` Cherry picking cruise-automation#33 --------- Co-authored-by: Srinath Avadhanula <srinath.avadhanula@getcruise.com>
Srinath Avadhanula authored and GitHub Enterprise committedJan 23, 2024 Configuration menu - View commit details
-
Copy full SHA for ef63c4d - Browse repository at this point
Copy the full SHA ef63c4dView commit details -
[TorchToTcp] lowering support for aten.size.int op (cruise-automation#35
Configuration menu - View commit details
-
Copy full SHA for 827a780 - Browse repository at this point
Copy the full SHA 827a780View commit details -
[TorchToTcp] Constrain dynamic legality condition for 2d convolutions (…
…cruise-automation#34) Conv 1D fails legalization in TorchToTosa, which I believe [only supports](https://sourcegraph.com/github.com/llvm/torch-mlir@faa4517e83d82348259165412d0744ba776360b3/-/blob/lib/Conversion/TorchToTosa/TorchToTosa.cpp?L1871) converting aten.convolution for the 2D case: ``` if (inputTy.getRank() != 4) return rewriter.notifyMatchFailure( op, "Unimplemented: only 2D convolutions supported"); ``` This makes it so we dynamically make just conv2d legal, so the remaining variants can convert to `tcp.custom_op`.
Configuration menu - View commit details
-
Copy full SHA for 2eff963 - Browse repository at this point
Copy the full SHA 2eff963View commit details -
Cherry-pick: aten.size.int and conv2d constrain (cruise-automation#13)
Cherry picking cruise-automation#35 and cruise-automation#34
Ze Zhang authored and GitHub Enterprise committedJan 23, 2024 Configuration menu - View commit details
-
Copy full SHA for 4eb3ce9 - Browse repository at this point
Copy the full SHA 4eb3ce9View commit details
Commits on Jan 31, 2024
-
MLIR-tcp Upgrade (cruise-automation#11)
Updates mlir-tcp to `90768ec2801ed9959144e8a1ca800e34ee2c7f54` resolves some minor merge conflicts around testing changes in [this PR](cruise-automation#28).
Aaron StGeorge authored and GitHub Enterprise committedJan 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 6d38b86 - Browse repository at this point
Copy the full SHA 6d38b86View commit details
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dcd1338 - Browse repository at this point
Copy the full SHA dcd1338View commit details
Commits on Feb 3, 2024
-
TCP Upgrade (cruise-automation#14)
[LLVM](https://github.com/llvm/llvm-project/tree/70eb0e37a86747f9266e4c8380baa89746f5e23b) (Jan 29) [StableHlo](https://github.com/openxla/stablehlo/tree/fd52182f76cadb82f2064fe5fc49a4fb4347a826) (Jan 31) [Torch-MLIR](https://github.com/llvm/torch-mlir/tree/c7d7d7f00494b588c31ac617e91354b12709009d) (Jan 31) [TCP](https://github.com/cruise-automation/mlir-tcp/tree/b0d474e30f04362c54cf29b9bdeb5bd697e7b2dc) (Feb 1)
Configuration menu - View commit details
-
Copy full SHA for 7f1899b - Browse repository at this point
Copy the full SHA 7f1899bView commit details
Commits on Feb 21, 2024
-
Cherry-pick from upstream for tensor.extract_slice (cruise-automation#15
) Cherry-pick from upstream PR: cruise-automation#39
Ze Zhang authored and GitHub Enterprise committedFeb 21, 2024 Configuration menu - View commit details
-
Copy full SHA for bb21cd2 - Browse repository at this point
Copy the full SHA bb21cd2View commit details
Commits on Mar 6, 2024
-
Merge branch 'main' into zezhang/upgrade_3_5
Ze Zhang committedMar 6, 2024 Configuration menu - View commit details
-
Copy full SHA for ff2d017 - Browse repository at this point
Copy the full SHA ff2d017View commit details -
remove hermetic python deps and python tests for internal repo
Ze Zhang committedMar 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 6945903 - Browse repository at this point
Copy the full SHA 6945903View commit details
Commits on Mar 7, 2024
-
TCP Upgrade (cruise-automation#16)
[LLVM](https://github.com/llvm/llvm-project/tree/e5ed7b6e2fd368b722b6359556cd0125881e7638) (Feb 27) [StableHlo](https://github.com/openxla/stablehlo/tree/d214e2e2bd568a80a9f25515907b64dd7b98c538) (Mar 5) [Torch-MLIR](https://github.com/llvm/torch-mlir/tree/a86e89ecb5c7929a39a38743fb7cacadf1ff41bb) (Mar 4) [TCP](https://github.com/cruise-automation/mlir-tcp/tree/8d5d10e91e1afc9a5bb88ac647de4929fa31d735) (Mar 5) Disable the python related tests that use the hermetic python deps
Ze Zhang authored and GitHub Enterprise committedMar 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 4680380 - Browse repository at this point
Copy the full SHA 4680380View commit details
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a44b76b - Browse repository at this point
Copy the full SHA a44b76bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc8b4ed - Browse repository at this point
Copy the full SHA cc8b4edView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef24d46 - Browse repository at this point
Copy the full SHA ef24d46View commit details
Commits on Apr 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3c78997 - Browse repository at this point
Copy the full SHA 3c78997View commit details
Commits on Apr 17, 2024
-
set generic name for executing tensor-rt engine (cruise-automation#19)
Replace the tcp custom op for `torch.tensorrt.execute_engine_variadic` to `tensorrt.execute_engine` for generic usage purpose. To test, from c/c repo: `bazel test @mlir-tcp//test/...`
Ze Zhang authored and GitHub Enterprise committedApr 17, 2024 Configuration menu - View commit details
-
Copy full SHA for 1b94201 - Browse repository at this point
Copy the full SHA 1b94201View commit details
Commits on Apr 19, 2024
-
Merge branch 'cruise_main' into raghavanr/upgrade_4_16
aaron-stgeorge committedApr 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 6292caa - Browse repository at this point
Copy the full SHA 6292caaView commit details
Commits on Apr 22, 2024
-
TCP Upgrade (cruise-automation#18)
[LLVM](https://github.com/llvm/llvm-project/tree/a952c123880eb1168f1021b116485e27170d48ca) (April 11) [Torch-MLIR](https://github.com/llvm/torch-mlir/tree/45eaeaaf3640f1f7f7b4743cf5844c3b9d519fdf) (April 12) [StableHlo](https://github.com/openxla/stablehlo/tree/271e8634de184fbfafd677d3876170feb6d08c97) (March 28) [TCP](https://github.com/cruise-automation/mlir-tcp/tree/04f327c698dd6f588ce09d8d9c99533c1e9855f9) (April 12)
Aaron StGeorge authored and GitHub Enterprise committedApr 22, 2024 Configuration menu - View commit details
-
Copy full SHA for c78a73e - Browse repository at this point
Copy the full SHA c78a73eView commit details
Commits on May 1, 2024
-
Muhammad Abubakar committed
May 1, 2024 Configuration menu - View commit details
-
Copy full SHA for fa0a65f - Browse repository at this point
Copy the full SHA fa0a65fView commit details -
Add create_tensor_from_int (cruise-automation#20)
TCP side changes for: https://github.robot.car/cruise/cruise/pull/239528
Muhammad Abubakar authored and GitHub Enterprise committedMay 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 456bb9c - Browse repository at this point
Copy the full SHA 456bb9cView commit details
Commits on May 8, 2024
-
Muhammad Abubakar committed
May 8, 2024 Configuration menu - View commit details
-
Copy full SHA for 22fc7d0 - Browse repository at this point
Copy the full SHA 22fc7d0View commit details
Commits on May 10, 2024
-
add test and incorporate feedback
Muhammad Abubakar committedMay 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 51a9bdf - Browse repository at this point
Copy the full SHA 51a9bdfView commit details
Commits on May 13, 2024
-
support index_from_tensor (cruise-automation#21)
Support lowering of the index_from_tensor op Part of: https://github.robot.car/cruise/cruise/pull/240509
Muhammad Abubakar authored and GitHub Enterprise committedMay 13, 2024 Configuration menu - View commit details
-
Copy full SHA for f3e6748 - Browse repository at this point
Copy the full SHA f3e6748View commit details
Commits on May 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cf71f96 - Browse repository at this point
Copy the full SHA cf71f96View commit details -
Sync with upstream (cruise-automation#22)
Picks the dynamic legality fixes to TorchToTcp amidst other changes.
Configuration menu - View commit details
-
Copy full SHA for f28249a - Browse repository at this point
Copy the full SHA f28249aView commit details
Commits on May 15, 2024
-
Muhammad Abubakar committed
May 15, 2024 Configuration menu - View commit details
-
Copy full SHA for 1677b79 - Browse repository at this point
Copy the full SHA 1677b79View commit details
Commits on May 16, 2024
-
Muhammad Abubakar committed
May 16, 2024 Configuration menu - View commit details
-
Copy full SHA for dd2d06a - Browse repository at this point
Copy the full SHA dd2d06aView commit details -
Add missing file from previous PR (cruise-automation#23)
Add missing file from previous PR
Muhammad Abubakar authored and GitHub Enterprise committedMay 16, 2024 Configuration menu - View commit details
-
Copy full SHA for aa8740f - Browse repository at this point
Copy the full SHA aa8740fView commit details -
handle create_tensor_from_index_array
Muhammad Abubakar committedMay 16, 2024 Configuration menu - View commit details
-
Copy full SHA for 3eb5a4d - Browse repository at this point
Copy the full SHA 3eb5a4dView commit details -
handle create_index_from_tensor_array
Muhammad Abubakar committedMay 16, 2024 Configuration menu - View commit details
-
Copy full SHA for be0f91d - Browse repository at this point
Copy the full SHA be0f91dView commit details -
support create_index_from_tensor
Muhammad Abubakar committedMay 16, 2024 Configuration menu - View commit details
-
Copy full SHA for ca86ee1 - Browse repository at this point
Copy the full SHA ca86ee1View commit details -
Muhammad Abubakar committed
May 16, 2024 Configuration menu - View commit details
-
Copy full SHA for 4741c39 - Browse repository at this point
Copy the full SHA 4741c39View commit details -
Move Tcp::IndexArrayType to CruiseInternal
Muhammad Abubakar committedMay 16, 2024 Configuration menu - View commit details
-
Copy full SHA for a7dde48 - Browse repository at this point
Copy the full SHA a7dde48View commit details
Commits on May 21, 2024
-
Create tensor from index array (cruise-automation#24)
Create tensor from index array handle
Muhammad Abubakar authored and GitHub Enterprise committedMay 21, 2024 Configuration menu - View commit details
-
Copy full SHA for a5b2c20 - Browse repository at this point
Copy the full SHA a5b2c20View commit details
Commits on May 29, 2024
-
LRDPrefilterPrediction Cleanup (cruise-automation#25)
Remove `LRDPrefilterPrediction` related content Test from c/c: `bazel test @mlir-tcp//test/...`
Ze Zhang authored and GitHub Enterprise committedMay 29, 2024 Configuration menu - View commit details
-
Copy full SHA for 8da2258 - Browse repository at this point
Copy the full SHA 8da2258View commit details
Commits on Jun 24, 2024
-
Allow creation of TCP groups where an op has multiple uses (cruise-au…
…tomation#74) We previously only allowed an op to have a single use during the creation a group for it. This PR relaxes that to allow multiple uses as long as all the uses belong to the same region. --------- Co-authored-by: Srinath Avadhanula <srinath.avadhanula@getcruise.com>
Configuration menu - View commit details
-
Copy full SHA for 913ffbb - Browse repository at this point
Copy the full SHA 913ffbbView commit details