-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): remote readonly accesses #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
read-mbeans
branch
from
March 15, 2023 21:02
ef029da
to
109f9b4
Compare
andrewazores
changed the title
feat(api): remote read access for MBeanMetrics
feat(api): remote readonly accesses
Mar 15, 2023
Signed-off-by: Andrew Azores <aazores@redhat.com>
Merged
7 tasks
maxcao13
reviewed
Mar 17, 2023
maxcao13
reviewed
Mar 17, 2023
maxcao13
reviewed
Mar 17, 2023
maxcao13
reviewed
Mar 17, 2023
maxcao13
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good as well too.
This was referenced Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
See https://github.com/cryostatio/cryostat/pull/1415
This does some refactoring, and then adds a capability for remote clients (the Cryostat server most likely) to retrieve select MBean metrics data over the HTTP API. This requires the same authentication as the discovery plugin flow.