feat(agent): implement HTTP-based readonly queries to -agents #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
agent-connection
branch
from
6dac6d9 to
296c940
Compare
|
Test image available: |
andrewazores
force-pushed
the
agent-connection
branch
from
0b772b3 to
25803c1
Compare
|
Test image available: |
andrewazores
force-pushed
the
agent-connection
branch
from
25803c1 to
029c312
Compare
|
Test image available: |
Signed-off-by: Andrew Azores <aazores@redhat.com>
Signed-off-by: Andrew Azores <aazores@redhat.com>
andrewazores
force-pushed
the
agent-connection
branch
from
029c312 to
a457a03
Compare
|
Test image available: |
maxcao13
approved these changes
Mar 17, 2023
This was referenced Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffFixes #1416
Fixes #1309
Fixes #520
Description of the change:
This fills in the implementation of one readonly query (MBean metrics) that Cryostat can perform against HTTP-based Cryostat Agent instances. This is simply achieved by wrapping around a Vert.x WebClient HTTP request and deserializing the response into the expected data type conforming to the same interface as what the JMX equivalent already does.
Motivation for the change:
See linked issues. This PR and others to come later provide a non-JMX alternate communications protocol so that Cryostat can be usefully deployed with no requirement on target applications to expose JMX connections.
How to manually test:
-agentPR,mvn installit, and rebuildquarkus-testsample application as usual.http://test application, and ensure that MBean Metrics chart card data displays.