External container integration tests #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
external-container-tests
branch
from
1133c16 to
6628340
Compare
Add test and utils to run an external container within the test pod, check that ContainerJFR discovers it, and then tear down
andrewazores
force-pushed
the
external-container-tests
branch
from
6628340 to
0aa1607
Compare
andrewazores
force-pushed
the
external-container-tests
branch
3 times, most recently
from
c958c86 to
e182fa3
Compare
andrewazores
force-pushed
the
external-container-tests
branch
3 times, most recently
from
b536515 to
38ee656
Compare
andrewazores
force-pushed
the
external-container-tests
branch
from
38ee656 to
3038c91
Compare
vic-ma
approved these changes
Jan 6, 2021
andrewazores
added a commit
to andrewazores/cryostat
that referenced
this pull request
Jan 7, 2021
* Update instructions for manual itest rerun * Set up test container inside a pod * Add basic external container discovery test Add test and utils to run an external container within the test pod, check that ContainerJFR discovers it, and then tear down * Move utility classes into util package * Mark test as disabled rather than commented out * Rename base class * Set pod name as property rather than hard-coded * Refactoring
andrewazores
added a commit
that referenced
this pull request
Jan 8, 2021
* External container integration tests (#376) * Update instructions for manual itest rerun * Set up test container inside a pod * Add basic external container discovery test Add test and utils to run an external container within the test pod, check that ContainerJFR discovers it, and then tear down * Move utility classes into util package * Mark test as disabled rather than commented out * Rename base class * Set pod name as property rather than hard-coded * Refactoring * Correct BasicCommandChannelIT expected hostnames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configuration to
pom.xmlfor the ContainerJFR integration test container instance to be wrapped into a pod, which is also set up and torn down when the integration test run starts/ends.A new test utility class is added which, for now, simply contains some helper methods to perform
podmaninvocations as subprocesses, for running/stopping containers within the integration test pod.Finally, a new integration test class is added which uses the above utility to run a
vertx-fib-demoinstance, wait for it to be inrunningstate, waits a bit more for JDP discovery to pick it up, and then simply tests that the ContainerJFR test instance is able to discover it.1. Marked as "draft" currently because when running the integration tests, the test runner reports that 2 tests were run in the new class - one skipped, and one (implicitly) passed. I'm not sure what the "skipped" test is supposed to be, where it comes from, or why it is skipped.2. The failsafe report for the new test class contains this:
For some reason in
main, theBasicCommandChannelITis simply not even run/reported. I'm not sure why the test runner does this.