[V1] external container itests #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update instructions for manual itest rerun * Set up test container inside a pod * Add basic external container discovery test Add test and utils to run an external container within the test pod, check that ContainerJFR discovers it, and then tear down * Move utility classes into util package * Mark test as disabled rather than commented out * Rename base class * Set pod name as property rather than hard-coded * Refactoring
vic-ma
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #376 . There was an adjustment to
BasicCommandChannelITrequired, which is included as a separate commit.mainhas this test disabled, so the correction was never made. Otherwise, the patch applied with only one minor merge conflict, also toBasicCommandChannelIT.