Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): avoid ConcurrentModificationException #433

Merged
merged 2 commits into from
May 4, 2024

Conversation

andrewazores
Copy link
Member

  • fix(recording): fix NPE when starting a recording without specified template type
  • fix(graphql): avoid ConcurrentModificationException

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #432

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@aali309
Copy link
Contributor

aali309 commented May 4, 2024

I will keep your changes and remove mine on e9b4de4

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores
Copy link
Member Author

I will keep your changes and remove mine on e9b4de4

Your transformToUni approach is quite good too actually, that looks like it also would have worked well. It might actually be worth doing it that way too, once the current threading and transaction issues (#415 #407 etc.) are fixed up and the GraphQL nonblocking execution is re-enabled...

@andrewazores
Copy link
Member Author

/build_test

Copy link

github-actions bot commented May 4, 2024

Workflow started at 5/4/2024, 1:10:09 AM. View Actions Run.

Copy link

github-actions bot commented May 4, 2024

No OpenAPI schema changes detected.

Copy link

github-actions bot commented May 4, 2024

No GraphQL schema changes detected.

Copy link

github-actions bot commented May 4, 2024

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/8948191333

@andrewazores andrewazores merged commit 6919e65 into cryostatio:main May 4, 2024
12 of 13 checks passed
@andrewazores andrewazores deleted the gh432 branch May 4, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] GraphQL deleteRecording mutation fails
2 participants