fix(db): correct use of Transactional annotation #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
gh412
branch
2 times, most recently
from
9f8ceed to
2ef8be7
Compare
|
/build_test |
|
Workflow started at 4/29/2024, 10:17:20 AM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
tthvo
reviewed
Apr 30, 2024
tthvo
reviewed
Apr 30, 2024
tthvo
reviewed
Apr 30, 2024
7 tasks
This was referenced May 3, 2024
aali309
reviewed
May 8, 2024
|
/build_test |
|
Workflow started at 5/8/2024, 11:38:18 AM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #405
Fixes: #440
Description of the change:
Removes useless instances of
Transactionalannotation and replaces them withQuarkusTransaction.joiningExisting()invocations where applicable.Motivation for the change:
Ensures operations actually occur in a transactional context as expected
How to manually test:
{ "id": 1, "name": "test", "description": "", "matchExpression": "target.connectUrl.contains('localhost:0')", "eventSpecifier": "template=Profiling,type=TARGET", "archivalPeriodSeconds": 10, "initialDelaySeconds": 0, "preservedArchives": 3, "maxAgeSeconds": 300, "maxSizeBytes": 0, "enabled": true }