Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(recordings): uploaded archives should be viewable with Grafana #541

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix(recordings): uploaded archives should be viewable with Grafana #541

merged 1 commit into from
Jun 28, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jun 28, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #540

Description of the change:

Consider connectUrl uploads as special case to use uploads as the jvmId.

Motivation for the change:

Uploaded archives can now be viewed with Grafana.

How to manually test:

  1. Built the cryostat container image or use CI snapshot image.
  2. Launch local smoketest with bash smoketest.bash -O.
  3. Upload any JFR file with the UI. The action should complete successfully and the archive should show up.
  4. Click on the far-right 3-dot and select View in Grafana.... This action should be work as expected.

@tthvo
fix(recordings): uploaded archives should be viewable with Grafana
d0be35b 
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
@tthvo tthvo requested a review from a team June 28, 2024 07:16
@tthvo
Copy link
Member Author

tthvo commented Jun 28, 2024

/build_test

@github-actions GitHub Actions
Copy link

Workflow started at 6/28/2024, 3:17:27 AM. View Actions Run.

@tthvo tthvo added the backport label Jun 28, 2024
@github-actions GitHub Actions
Copy link

No GraphQL schema changes detected.

@github-actions GitHub Actions
Copy link

No OpenAPI schema changes detected.

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat/actions/runs/9708987588

@andrewazores andrewazores merged commit 727d14b into cryostatio:main Jun 28, 2024
15 of 16 checks passed
mergify bot pushed a commit that referenced this pull request Jun 28, 2024
@tthvo @mergify
fix(recordings): uploaded archives should be viewable with Grafana (#541
74c0c2b 
)

Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
(cherry picked from commit 727d14b)
@mergify mergify bot mentioned this pull request Jun 28, 2024
Merged
7 tasks
@tthvo tthvo deleted the grafana-for-upload branch June 28, 2024 19:26
andrewazores pushed a commit that referenced this pull request Jul 4, 2024
@mergify @tthvo
fix(recordings): uploaded archives should be viewable with Grafana (b…
967789b 
…ackport #541) (#542)

fix(recordings): uploaded archives should be viewable with Grafana (#541)

Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
(cherry picked from commit 727d14b)

Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
backport fix safe-to-test
Projects
4.0.0 release
Status: Done
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Uploaded archives cannot be viewed in Grafana
2 participants
@tthvo @andrewazores