Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recordings): uploaded archives should be viewable with Grafana (backport #541) #542

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 28, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #540

Description of the change:

Consider connectUrl uploads as special case to use uploads as the jvmId.

Motivation for the change:

Uploaded archives can now be viewed with Grafana.

How to manually test:

  1. Built the cryostat container image or use CI snapshot image.
  2. Launch local smoketest with bash smoketest.bash -O.
  3. Upload any JFR file with the UI. The action should complete successfully and the archive should show up.
  4. Click on the far-right 3-dot and select View in Grafana.... This action should be work as expected.

This is an automatic backport of pull request #541 done by [Mergify](https://mergify.com).

)

Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
(cherry picked from commit 727d14b)
@andrewazores
Copy link
Member

This is too late to make it into 3.0.0, but it looks like we'll have a 3.0.1 fairly soon after. Will merge this for 3.0.1 once the 3.0.0 is finalized and released.

@andrewazores
Copy link
Member

Whoops.

@andrewazores andrewazores reopened this Jun 28, 2024
@andrewazores andrewazores merged commit 967789b into cryostat-v3.0 Jul 4, 2024
20 of 21 checks passed
@mergify mergify bot deleted the mergify/bp/cryostat-v3.0/pr-541 branch July 4, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants