Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cryostat3): update for 3.0 release #180

Merged
merged 14 commits into from
Jul 4, 2024
Merged

feat(cryostat3): update for 3.0 release #180

merged 14 commits into from
Jul 4, 2024

Conversation

andrewazores and others added 14 commits July 4, 2024 09:14
Co-authored-by: Atif Ali <atali@redhat.com>
* update screenshot

* document 'restart if recording already exists' checkbox

* add link to guide for creating custom event template

* remove unnecessary formatting from term
* link more tools

* update screenshot

* update file extension

* remove JMC mention, already mentioned earlier in guide steps
…localhost:0 (#188)

* fix(custom-targets): remove restriction on k8s jfr-jmx/9091, explain localhost:0

* provide more reasons connection test may fail

* formatting
* expression is CEL

* target includes jvmId

* spacing

* formatting

* capitalization

* link other guides

* correct quotation marks

* correct regex syntax

* correct examples for labels/annotations maps and optional keys

* correct example expr
@andrewazores andrewazores marked this pull request as ready for review July 4, 2024 13:14
@andrewazores andrewazores merged commit 56042c8 into main Jul 4, 2024
2 checks passed
@andrewazores andrewazores deleted the cryostat3 branch July 4, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant