-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cryostat3): update for 3.0 release #180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
added
feat
New feature or request
docs
Improvements or additions to documentation
labels
May 27, 2024
This was referenced Jun 10, 2024
Co-authored-by: Atif Ali <atali@redhat.com>
* update screenshot * document 'restart if recording already exists' checkbox * add link to guide for creating custom event template * remove unnecessary formatting from term
* link more tools * update screenshot * update file extension * remove JMC mention, already mentioned earlier in guide steps
…localhost:0 (#188) * fix(custom-targets): remove restriction on k8s jfr-jmx/9091, explain localhost:0 * provide more reasons connection test may fail * formatting
* expression is CEL * target includes jvmId * spacing * formatting * capitalization * link other guides * correct quotation marks * correct regex syntax * correct examples for labels/annotations maps and optional keys * correct example expr
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: