Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-targets): remove restriction on k8s jfr-jmx/9091, explain localhost:0 #188

Merged

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented May 31, 2024

  • fix(custom-targets): remove restriction on k8s jfr-jmx/9091, explain localhost:0
  • provide more reasons connection test may fail
  • formatting

See cryostatio/cryostat#488 , cryostatio/cryostat-web#1262

@andrewazores andrewazores merged commit 1cfdd5f into cryostatio:cryostat3 Jun 11, 2024
2 checks passed
@andrewazores andrewazores deleted the cryostat3-custom-targets branch June 11, 2024 13:23
andrewazores added a commit to andrewazores/cryostatio.github.io that referenced this pull request Jun 11, 2024
…localhost:0 (cryostatio#188)

* fix(custom-targets): remove restriction on k8s jfr-jmx/9091, explain localhost:0

* provide more reasons connection test may fail

* formatting
andrewazores added a commit that referenced this pull request Jun 11, 2024
…localhost:0 (#188)

* fix(custom-targets): remove restriction on k8s jfr-jmx/9091, explain localhost:0

* provide more reasons connection test may fail

* formatting
andrewazores added a commit that referenced this pull request Jul 4, 2024
…localhost:0 (#188)

* fix(custom-targets): remove restriction on k8s jfr-jmx/9091, explain localhost:0

* provide more reasons connection test may fail

* formatting
andrewazores added a commit that referenced this pull request Jul 4, 2024
* chore(release): copy current docs to versioned 2.4.0 (#178)

* docs(guides): update guide for trusted TLS certs (#181)

* docs(credentials): remove references to Session credentials storage (#182)

* docs(grafana): remove references to separate login credentials (#183)

* docs(versions): bump k8s and OpenShift min versions (#184)

* feat(get-started): document Agent dynamic attach (#185)

Co-authored-by: Atif Ali <atali@redhat.com>

* fix(dashboard): fix image links and a typo on dashboard guide (#186)

* fix(topology): remove outdated caution note (#187)

* docs(guides): update guide for starting/stopping recordings (#190)

* update screenshot

* document 'restart if recording already exists' checkbox

* add link to guide for creating custom event template

* remove unnecessary formatting from term

* docs(guides): update guide for download recording (#191)

* link more tools

* update screenshot

* update file extension

* remove JMC mention, already mentioned earlier in guide steps

* docs(guides): update formatting in guide for editing template using JMC (#192)

* fix(custom-targets): remove restriction on k8s jfr-jmx/9091, explain localhost:0 (#188)

* fix(custom-targets): remove restriction on k8s jfr-jmx/9091, explain localhost:0

* provide more reasons connection test may fail

* formatting

* docs(guides): update doc for automated rule creation (#193)

* expression is CEL

* target includes jvmId

* spacing

* formatting

* capitalization

* link other guides

* correct quotation marks

* correct regex syntax

* correct examples for labels/annotations maps and optional keys

* correct example expr

* feat(blog): add post for 3.0.0 release (#177)

---------

Co-authored-by: Atif Ali <atali@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants