Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: decode tx is unnecessary in tx listener #1467

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Problem: decode tx is unnecessary in tx listener #1467

merged 1 commit into from
Jun 10, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jun 10, 2024 •
edited by coderabbitai bot
Loading

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • New Features

    • Improved transaction listener efficiency by avoiding unnecessary transaction decoding.

  • Chores

    • Updated dependencies for github.com/crypto-org-chain/ethermint and github.com/evmos/ethermint to the latest versions.

@mmsqe mmsqe requested a review from a team as a code owner June 10, 2024 01:20
@mmsqe mmsqe requested review from calvinaco and devashishdxt and removed request for a team June 10, 2024 01:20
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 10, 2024 •
edited
Loading

Walkthrough

This update primarily focuses on refining the transaction handling within the cronos application. Key changes include optimizing the transaction listener to avoid unnecessary decoding, updating dependencies, and modifying the application logic to utilize the new PendingTxListener from evmante. These improvements aim to enhance performance and maintain compatibility with the latest versions of dependencies.

Changes

Files Change Summary
CHANGELOG.md Added a note about avoiding unnecessary transaction decoding in the transaction listener.
app/app.go Updated imports, replaced PendingTxListener, modified ExtraDecorators, and updated methods.
go.mod Updated github.com/crypto-org-chain/ethermint to a newer version.
gomod2nix.toml Updated version and hash values for the github.com/evmos/ethermint module.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant evmante

    User->>App: Submit transaction
    App->>evmante: RegisterPendingTxListener
    evmante->>App: onPendingTx event
    App-->>User: Acknowledge transaction
Loading

Poem

In code's vast sea, where changes flow,
A tweak to make transactions glow.
With evmante's touch, we now refine,
To keep our app in perfect line.
Dependencies updated, swift and neat,
Our blockchain path, a rhythmic beat.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 84e7c7d and 9fc2788.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (4)
  • CHANGELOG.md (1 hunks)
  • app/app.go (4 hunks)
  • go.mod (1 hunks)
  • gomod2nix.toml (1 hunks)
Files skipped from review due to trivial changes (1)
  • go.mod
Additional context used
LanguageTool
CHANGELOG.md

[grammar] ~21-~21: The conjunction “when” requires the past participle “registered”. Or did you mean “you register”? (IF_VB_PCT)
Context: ...ronos/pull/1421) Validate e2ee key when register. * (store) [#1448](https://github.com/c...

[misspelling] ~127-~127: Did you mean “or”? ‘Of’ refers to parts of a whole, while ‘or’ refers to alternatives. (CONFUSION_OF_OR)
Context: ...onos/pull/1216) Update ethermint to fix of avoid redundant parse chainID from gens...

[uncategorized] ~127-~127: This verb may not be in the correct form. Consider using a different form for this context. (AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
Context: ...edundant parse chainID from gensis when start server. - [#1230](https://github.com/cr...

[uncategorized] ~139-~139: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...52) Add plan v1.1.0-testnet to update default max_callback_gas param. ### Improvemen...

[style] ~168-~168: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...n processing and double spend check. - [cronos#742](https://github.com/crypto-org-chai...

[style] ~169-~169: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...e handler for v0.8.0-gravity-alpha2. - [cronos#750](https://github.com/crypto-org-chai...

[style] ~170-~170: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...e handler for v0.8.0-gravity-alpha3. - [cronos#769](https://github.com/crypto-org-chai...

[uncategorized] ~170-~170: This verb may not be in the correct form. Consider using a different form for this context. (AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
Context: ...l/769) Prevent cancellation function to be called outside the scope of the contrac...

[uncategorized] ~170-~170: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ... outside the scope of the contract that manage it. - [cronos#775](https://github.com/c...

[style] ~171-~171: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...cope of the contract that manage it. - [cronos#775](https://github.com/crypto-org-chai...

[style] ~172-~172: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...775) Support turnbridge transaction. - [cronos#781](https://github.com/crypto-org-chai...

[uncategorized] ~172-~172: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...m//pull/781) Add prune command. - [cronos#830](https://github....

[style] ~173-~173: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: .../cronos/pull/781) Add prune command. - [cronos#830](https://github.com/crypto-org-chai...

[style] ~176-~176: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...upgrade handler for v2.0.0-testnet3. - [cronos#795](https://github.com/crypto-org-chai...

[style] ~177-~177: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: .../795) Support permissions in cronos. - [cronos#997](https://github.com/crypto-org-chai...

[style] ~178-~178: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ontract for cronos originated crc20. - [cronos#1005](https://github.com/crypto-org-cha...

[style] ~179-~179: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...o-ibc event in case of source token. - [cronos#1069](https://github.com/crypto-org-cha...

[style] ~180-~180: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...o v1.10.26 and ibc-go to v6.2.0. - [cronos#1147](https://github.com/crypto-org-cha...

[style] ~184-~184: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...adjusted correctly in ibc-go v7.2.0. - [cronos#1163](https://github.com/crypto-org-cha...

[style] ~185-~185: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ateful precompiled contract for ica. - [cronos#837](https://github.com/crypto-org-chai...

[style] ~186-~186: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...teful precompiled contract for bank. - [cronos#1184](https://github.com/crypto-org-cha...

[style] ~187-~187: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ull/1184) Update ibc-go to v7.3.1. - [cronos#1186](https://github.com/crypto-org-cha...

[style] ~188-~188: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... max block gas limit in new version. - [cronos#1187](https://github.com/crypto-org-cha...

[style] ~189-~189: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...1187) Disable gravity module in app. - [cronos#1185](https://github.com/crypto-org-cha...

[style] ~190-~190: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...nos/pull/1185) Support ibc callback. - [cronos#1196](https://github.com/crypto-org-cha...

[grammar] ~209-~209: It seems that “to” is missing before the verb. (MISSING_TO_BETWEEN_BE_AND_VB)
Context: .../cronos/pull/1150) Fix memiavl's unsafe retain of the root hashes. ### Features - [#...

[misspelling] ~213-~213: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’? (CLEAN_UP)
Context: .../pull/1042) call Close method on app to cleanup resource on graceful shutdown ([ethermi...

[uncategorized] ~214-~214: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ...pto-org-chain/cronos/pull/1083) memiavl support both sdk 46 and 47 root hash rules. - [...

[uncategorized] ~216-~216: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ...pto-org-chain/cronos/pull/1100) memiavl support read-only mode, and grab exclusive lock...

[uncategorized] ~226-~226: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ...ypto-org-chain/cronos/pull/924) memiavl support Export API. - [#950](https://github.c...

[uncategorized] ~257-~257: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...949) Release static-linked binaries for linux platform. - [#934](https://github.com/c...

[uncategorized] ~328-~328: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...m//pull/781) Add prune command. - [#790](https://github.com/cr...

[grammar] ~329-~329: After ‘it’, use the third-person verb form “fixes”. (IT_VBZ)
Context: ...790) Update cosmos-sdk to v0.46.7, it fix a migration issue which affects pending...

[style] ~396-~396: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...file state streamer (backport #702). - [cronos#730](https://github.com/crypto-org-chai...

[uncategorized] ~416-~416: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...0, cosmos sdk to v0.45.4 and gravity to latest, remove v0.7.0 related upgradeHandler. ...

[style] ~418-~418: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...elSendToChain support from evm call. - [cronos#600](https://github.com/crypto-org-chai...

[style] ~419-~419: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...plement bidirectional token mapping. - [cronos#611](https://github.com/crypto-org-chai...

[style] ~420-~420: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...owledgement error in ibc middleware. - [cronos#627](https://github.com/crypto-org-chai...

[style] ~435-~435: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...leware, use ibc-go upstream version. - [cronos#550](https://github.com/crypto-org-chai...

[style] ~436-~436: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...basic json-rpc apis on pruned nodes. - [cronos#549](https://github.com/crypto-org-chai...

[style] ~437-~437: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...tom tx indexer feature of ethermint. - [cronos#673](https://github.com/crypto-org-chai...

[style] ~455-~455: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ed in json-rpc apis (backport #502). - [cronos#526](https://github.com/crypto-org-chai...

[style] ~456-~456: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... Fix tendermint duplicated tx issue. - [cronos#584](https://github.com/crypto-org-chai...

[style] ~457-~457: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...shes returned in some JSON-RPC apis. - [cronos#587](https://github.com/crypto-org-chai...

[style] ~458-~458: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... tx patch cmd recompute eth tx hash. - [cronos#595](https://github.com/crypto-org-chai...

[style] ~464-~464: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...nd to patch txs post v0.7.0 upgrade. - [cronos#522](https://github.com/crypto-org-chai...

[style] ~465-~465: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... the tendermint tx duplicated issue. - [cronos#585](https://github.com/crypto-org-chai...

[style] ~479-~479: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ase fee related logic in the code. - [ethermint#817](https://github.com/tharsis/ethermi...

[style] ~480-~480: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ogic related to effectiveGasPrice. - [ethermint#822](https://github.com/tharsis/ethermi...

[style] ~483-~483: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... tx when block gas limit exceeded. - [cosmos-sdk#10725](https://github.com/cosmos/cosmos...

[style] ~491-~491: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...e url query parameter in swagger-ui. - [cronos#328](https://github.com/crypto-org-chai...

[uncategorized] ~491-~491: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ...b.com//pull/328) display detail panic information in query resul...

[style] ~492-~492: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...query result when --trace enabled. - [cronos#441](https://github.com/crypto-org-chai...

[uncategorized] ~497-~497: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ... Upgrade gravity bridge to v0.3.9 which contain a bugfix on batchTxExecuted. - [crono...

[style] ~499-~499: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ...ll/329) Fix panic of eth_call on blocks prior to upgrade. - [cronos#340](https://github....

[style] ~500-~500: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...eth_call on blocks prior to upgrade. - [cronos#340](https://github.com/crypto-org-chai...

[style] ~501-~501: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t, b) fix data races traceContext. - [cronos#370](https://github.com/crypto-org-chai...

[style] ~502-~502: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...g, add websockets integration tests. - [cronos#378](https://github.com/crypto-org-chai...

[uncategorized] ~502-~502: This verb may not be in the correct form. Consider using a different form for this context. (AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
Context: ...bug fixes: a) fix tx inclusion issue by report correct gasWanted of eth tx, b) Add buf...

[style] ~503-~503: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... add returnValue message on tracing. - [cronos#446](https://github.com/crypto-org-chai...

[uncategorized] ~511-~511: You might be missing the article “a” here. (AI_EN_LECTOR_MISSING_DETERMINER_A)
Context: ...in/cronos/pull/255) fix empty topics in non-breaking way - [cronos#270](https://git...

[uncategorized] ~559-~559: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...l/187) multiple denoms can be mapped to same contract - [cronos#157](https://github....

[uncategorized] ~568-~568: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ... 2021* ## v0.6.0 This version removes gravity-bridge from cronos, also includes multi...

[uncategorized] ~611-~611: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ...th a patched version of ethermint which include a bug fix on the transaction receipts e...

[uncategorized] ~623-~623: This verb may not be in the correct tense. Consider changing the tense to fit the context better. (AI_EN_LECTOR_REPLACEMENT_VERB_TENSE)
Context: ...org Chain. In addition to that, it also upgrade ethermint to its latest version (v0.5.0...

[uncategorized] ~623-~623: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ... to its latest version (v0.5.0.x) which bring several breaking changes (see [changelo...

[uncategorized] ~667-~667: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...arsis/ethermint/issues/342) Don't clear balance when resetting the account. - (ethermin...

Markdownlint
CHANGELOG.md

51-51: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

63-63: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

71-71: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

79-79: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

87-87: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

88-88: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

89-89: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

93-93: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

101-101: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

102-102: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

103-103: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

104-104: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

105-105: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

106-106: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

110-110: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

111-111: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

117-117: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

118-118: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

119-119: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

120-120: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

121-121: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

125-125: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

126-126: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

127-127: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

128-128: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

129-129: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

137-137: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

138-138: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

139-139: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

143-143: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

144-144: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

145-145: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

153-153: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

154-154: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

158-158: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

166-166: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

167-167: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

168-168: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

169-169: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

170-170: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

171-171: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

172-172: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

173-173: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

174-174: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

175-175: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

176-176: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

177-177: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

178-178: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

179-179: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

180-180: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

181-181: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

182-182: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

183-183: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

184-184: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

185-185: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

186-186: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

187-187: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

188-188: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

189-189: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

190-190: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

194-194: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

195-195: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

196-196: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

197-197: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

198-198: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

199-199: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

200-200: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

201-201: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

202-202: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

203-203: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

204-204: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

205-205: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

206-206: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

207-207: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

208-208: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

209-209: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

213-213: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

214-214: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

215-215: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

216-216: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

217-217: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

218-218: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

219-219: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

220-220: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

224-224: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

239-239: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

240-240: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

241-241: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

242-242: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

243-243: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

244-244: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

245-245: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

246-246: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

247-247: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

248-248: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

256-256: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

257-257: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

258-258: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

262-262: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

263-263: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

264-264: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

265-265: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

266-266: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

267-267: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

268-268: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

276-276: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

284-284: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

288-288: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

289-289: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

290-290: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

298-298: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

302-302: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

303-303: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

304-304: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

312-312: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

320-320: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

328-328: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

329-329: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

338-338: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

346-346: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

354-354: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

362-362: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

363-363: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

364-364: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

365-365: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

373-373: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

381-381: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

382-382: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

390-390: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

394-394: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

395-395: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

396-396: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

404-404: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

416-416: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

417-417: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

418-418: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

419-419: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

420-420: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

421-421: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

422-422: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

426-426: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

427-427: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

428-428: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

432-432: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

433-433: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

434-434: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

435-435: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

436-436: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

437-437: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

445-445: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

453-453: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

454-454: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

455-455: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

456-456: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

457-457: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

458-458: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

462-462: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

463-463: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

464-464: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

465-465: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

473-473: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

474-474: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

475-475: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

476-476: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

477-477: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

478-478: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

479-479: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

480-480: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

481-481: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

482-482: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

483-483: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

484-484: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

488-488: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

489-489: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

490-490: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

491-491: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

492-492: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

496-496: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

497-497: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

498-498: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

499-499: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

500-500: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

501-501: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

502-502: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

503-503: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

511-511: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

512-512: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

520-520: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

528-528: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

529-529: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

530-530: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

534-534: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

535-535: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

543-543: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

544-544: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

545-545: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

546-546: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

547-547: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

555-555: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

559-559: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

560-560: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

561-561: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

562-562: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

572-572: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

576-576: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

577-577: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

578-578: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

579-579: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

583-583: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

584-584: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

595-595: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

596-596: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

597-597: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

598-598: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

599-599: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

603-603: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

604-604: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

605-605: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

615-615: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

616-616: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

627-627: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

631-631: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

632-632: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

633-633: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

634-634: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

635-635: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

636-636: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

638-638: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

639-639: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

647-647: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

651-651: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

655-655: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

665-665: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

666-666: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

667-667: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

668-668: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

674-674: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

675-675: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

679-679: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

37-37: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

45-45: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

57-57: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

65-65: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

73-73: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

81-81: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

95-95: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

113-113: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

147-147: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

160-160: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

250-250: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

270-270: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

278-278: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

292-292: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

306-306: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

314-314: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

322-322: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

332-332: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

340-340: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

348-348: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

356-356: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

367-367: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

375-375: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

384-384: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

398-398: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

406-406: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

410-410: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

439-439: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

447-447: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

467-467: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

505-505: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

514-514: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

522-522: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

537-537: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

549-549: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

564-564: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

586-586: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

607-607: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

618-618: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

641-641: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

657-657: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

Additional comments not posted (6)
gomod2nix.toml (1)

265-266: Updated github.com/evmos/ethermint to v0.6.1-0.20240609125548-217e3af48fa5 with a new hash. Ensure the hash corresponds to the actual module content.

CHANGELOG.md (1)

25-25: The entry for PR #1467 is well-documented in the CHANGELOG. It succinctly captures the essence of the changes made in the transaction listener to avoid unnecessary transaction decoding.

app/app.go (4)

168-168: Import of github.com/ethereum/go-ethereum/common added.

This import is necessary for the changes in the App struct and the onPendingTx method to handle Ethereum common hashes.

292-292: Change in the type of pendingTxListeners from evmapp.PendingTxListener to evmante.PendingTxListener.

This change aligns with the PR's objective to update the transaction listener interface, ensuring it uses the correct type from the evmante package.

1288-1289: Updated the RegisterPendingTxListener method to accept evmante.PendingTxListener instead of evmapp.PendingTxListener.

This update is consistent with the change in the App struct's pendingTxListeners field, ensuring type consistency across the application.

1293-1295: Updated the onPendingTx method to handle the new listener type.

The method now correctly iterates over the updated pendingTxListeners list, calling each listener with the transaction hash. This change is necessary for the new listener interface.

@mmsqe mmsqe added this pull request to the merge queue Jun 10, 2024
Merged via the queue into crypto-org-chain:main with commit 7866871 Jun 10, 2024
37 checks passed
mmsqe added a commit that referenced this pull request Jun 10, 2024
@mmsqe
Problem: decode tx is unnecessary in tx listener (backport: #1467) (#…
ba0e7b3 
…1468)

* Problem: decode tx is unnecessary in tx listener

* fix lint
@mmsqe mmsqe mentioned this pull request Jul 5, 2024
Closed
@coderabbitai coderabbitai bot mentioned this pull request Sep 27, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@yihuang yihuang yihuang approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner automatically assigned from crypto-org-chain/cronos-dev

@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @yihuang