Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: pebbledb backend is not tested #934

Merged
merged 5 commits into from
Apr 13, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 16, 2023

Solution:

  • enable the backend and test in integration tests

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang yihuang marked this pull request as ready for review April 12, 2023 13:41
@yihuang yihuang requested a review from a team as a code owner April 12, 2023 13:41
@yihuang yihuang requested review from mmsqe and thomas-nguy and removed request for a team April 12, 2023 13:41
@yihuang yihuang added the backport/v1.0.x backport to release/v1.0.x label Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #934 (9300e83) into main (7ba584c) will increase coverage by 22.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #934       +/-   ##
===========================================
+ Coverage   21.57%   43.81%   +22.24%     
===========================================
  Files          48       62       +14     
  Lines        3004     4838     +1834     
===========================================
+ Hits          648     2120     +1472     
- Misses       2293     2469      +176     
- Partials       63      249      +186     

see 67 files with indirect coverage changes

@yihuang yihuang enabled auto-merge (squash) April 13, 2023 00:35
@yihuang yihuang merged commit f5fcb13 into crypto-org-chain:main Apr 13, 2023
@yihuang yihuang deleted the test-pebble branch April 13, 2023 01:34
yihuang added a commit to yihuang/cronos that referenced this pull request Apr 13, 2023
* Problem: pebbledb backend is not tested

Solution:
- enable the backend and test in integration tests

* fix upgrade integration test

* fix versiondb integration test

* update dependency repo

* pin pebbledb to released version
yihuang added a commit that referenced this pull request Apr 13, 2023
* Problem: pebbledb backend is not tested

Solution:
- enable the backend and test in integration tests

* fix upgrade integration test

* fix versiondb integration test

* update dependency repo

* pin pebbledb to released version
yihuang added a commit to yihuang/cronos that referenced this pull request Apr 13, 2023
… (crypto-org-chain#972)

* Problem: pebbledb backend is not tested

Solution:
- enable the backend and test in integration tests

* fix upgrade integration test

* fix versiondb integration test

* update dependency repo

* pin pebbledb to released version
AleksandM pushed a commit to AleksandM/cronos that referenced this pull request Jan 23, 2024
… (crypto-org-chain#972)

* Problem: pebbledb backend is not tested

Solution:
- enable the backend and test in integration tests

* fix upgrade integration test

* fix versiondb integration test

* update dependency repo

* pin pebbledb to released version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.0.x backport to release/v1.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants