-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: pebbledb backend is not tested #934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
commented
Mar 16, 2023
Solution: - enable the backend and test in integration tests
yihuang
requested review from
mmsqe and
thomas-nguy
and removed request for
a team
April 12, 2023 13:41
Codecov Report
@@ Coverage Diff @@
## main #934 +/- ##
===========================================
+ Coverage 21.57% 43.81% +22.24%
===========================================
Files 48 62 +14
Lines 3004 4838 +1834
===========================================
+ Hits 648 2120 +1472
- Misses 2293 2469 +176
- Partials 63 249 +186 |
mmsqe
approved these changes
Apr 12, 2023
yihuang
added a commit
to yihuang/cronos
that referenced
this pull request
Apr 13, 2023
* Problem: pebbledb backend is not tested Solution: - enable the backend and test in integration tests * fix upgrade integration test * fix versiondb integration test * update dependency repo * pin pebbledb to released version
yihuang
added a commit
that referenced
this pull request
Apr 13, 2023
yihuang
added a commit
to yihuang/cronos
that referenced
this pull request
Apr 13, 2023
… (crypto-org-chain#972) * Problem: pebbledb backend is not tested Solution: - enable the backend and test in integration tests * fix upgrade integration test * fix versiondb integration test * update dependency repo * pin pebbledb to released version
AleksandM
pushed a commit
to AleksandM/cronos
that referenced
this pull request
Jan 23, 2024
… (crypto-org-chain#972) * Problem: pebbledb backend is not tested Solution: - enable the backend and test in integration tests * fix upgrade integration test * fix versiondb integration test * update dependency repo * pin pebbledb to released version
13 tasks
This was referenced Apr 26, 2024
13 tasks
This was referenced Jun 3, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)