Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): nextBaseFee for fee history (backport: #1720) #234

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Mar 28, 2023

for more info: evmos#1720

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@github-advanced-security
Copy link

You have successfully added a new Semgrep configuration .github/workflows/semgrep.yml:semgrep. As part of the setup process, we have scanned this repository and found 41 existing alerts. Please check the repository Security tab to see all alerts.

@mmsqe mmsqe requested review from yihuang and calvinaco March 28, 2023 12:49
@mmsqe mmsqe marked this pull request as ready for review March 28, 2023 12:49
@github-advanced-security
Copy link

You have successfully added a new gosec configuration .github/workflows/security.yml:Gosec. As part of the setup process, we have scanned this repository and found 141 existing alerts. Please check the repository Security tab to see all alerts.

}
}
}(int32(blockID - blockStart + int64(i)))

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion

Potential integer overflow by integer type conversion
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #234 (cc25207) into release/v0.20.x-cronos (cb741e1) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.20.x-cronos     #234      +/-   ##
==========================================================
- Coverage                   57.20%   56.81%   -0.40%     
==========================================================
  Files                         108      108              
  Lines                       10149    10220      +71     
==========================================================
  Hits                         5806     5806              
- Misses                       4096     4167      +71     
  Partials                      247      247              
Impacted Files Coverage Δ
rpc/backend/chain_info.go 8.99% <0.00%> (-1.13%) ⬇️
rpc/backend/utils.go 6.60% <0.00%> (-1.87%) ⬇️

@mmsqe mmsqe changed the title fix(rpc): nextBaseFee for fee history (backport: #1770) fix(rpc): nextBaseFee for fee history (backport: #1720) Mar 28, 2023
…port-1720

Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang merged commit 0efdee3 into crypto-org-chain:release/v0.20.x-cronos Apr 3, 2023
yihuang added a commit to yihuang/cronos that referenced this pull request Apr 3, 2023
Solution:
- update ethermint to include two bug fixes
  - crypto-org-chain/ethermint#234
  - crypto-org-chain/ethermint#233
- update cosmos-sdk to include one bug fix
  - cosmos/cosmos-sdk#15667
yihuang added a commit to yihuang/cronos that referenced this pull request Apr 3, 2023
Solution:
- update ethermint to include two bug fixes
  - crypto-org-chain/ethermint#234
  - crypto-org-chain/ethermint#233
- update cosmos-sdk to include one bug fix
  - cosmos/cosmos-sdk#15667
yihuang added a commit to crypto-org-chain/cronos that referenced this pull request Apr 4, 2023
* Problem: recent bug fixes not included

Solution:
- update ethermint to include two bug fixes
  - crypto-org-chain/ethermint#234
  - crypto-org-chain/ethermint#233
- update cosmos-sdk to include one bug fix
  - cosmos/cosmos-sdk#15667

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* debug lint

* fix linter

---------

Signed-off-by: yihuang <huang@crypto.com>
mmsqe added a commit that referenced this pull request Jun 14, 2023
* fix(rpc): nextBaseFee for fee history (backport: evmos#1720) (#234)

* fix blk number for next base fee

* add test

* add change doc

* cross check next fee

* calc base fee based on params

elasticity_multiplier & base_fee_change_denominator

* concurrent call with maxBlockFetchers

* test with get feemarket params

* Update CHANGELOG.md

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>

* fix(rpc): add more invalid check for fee history (backport: evmos#1720)  (#241)

* align request beyond head block

* align invalid reward percentile

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants