update secp256k1 to v4.0

[homura]

Since secp256k1 v4.0 use the N-API, this can avoid some unexpected situations similar to when worker_thread calls binding and use Pure JS version

Try the following code, and run with secp256k1@3.8 and secp256k1@4.0, you will find that in the worker_thread, the error caused by Module did not self-register will cause its performance to decrease due to the implementation of the JS version

const { Worker, isMainThread } = require("worker_threads");

process.env.DEBUG = "*";

if (isMainThread) {
  new Worker(__filename);
  const secp256k1 = require("secp256k1");

} else {
  const secp256k1 = require("secp256k1");
}

[junderw]

utACK it looks good to me.

[junderw]

Bonus: found #33 when verifying this code change.

[holgerd77]

Any chance this gets merged and released soon?

[holgerd77]

Hi, just wanted to give this a cautious iteration: we have an outstanding release - see ethereumjs/ethereumjs-wallet#113 - and a merge and subsequent release here would substantially improve the installation experience since one main part was to update the secp256k1 dependencies to v4.0 coming with the pre-build binaries.

If not possible so be it but otherwise a release here would be super cool! 😄

[jprichardson]

@holgerd77 thanks. I had no idea this was used in ethereumjs-wallet. Will have this merged and updated.

[holgerd77]

@jprichardson Thanks, that's so great! 😄

[RyanZim]

Published in v2.0.0 🎉

[holgerd77]

Thanks for the release, great! 😄

We have some tests failing now with the updated version. Didn't get a chance to have a look yet, but just to already raise some awareness here.