Bug: Derive only takes string while deriveChild takes index #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Yikes. utACK. |
RyanZim
reviewed
Apr 15, 2020
|
Can someone give me a guess of how rare this bug would have been, and what kinds of conditions would have triggered it? I'm investigating possible causes of another issue, and I'd like to rule this out if possible. |
|
The chance of hitting this bug is 0.000000000000000000000000000000000000373 % per every derivation level. tbh by the time anyone hits this bug the heat death of the universe will be upon us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I doubt anyone has ever hit this bug, but it's still a bug.
No clue how we could test for it though...