Fix crash for some android device when completeInitialize() in Speech… #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sowens-csd
reviewed
Jun 30, 2023
There was a problem hiding this comment.
Can you explain the failure you're seeing and how this change fixes it? I think it takes the SpeechRecognizer.isOnDeviceRecognitionAvailable out of the initialization path in the case where recognition is available? If the problem is the call to SpeechRecognizer.isOnDeviceRecognitionAvailable then wouldn't this still crash in some cases?
|
Could you have a look at PR 409? I think it is addressing the same issue, if so I will close this PR and use 409. |
|
Duplicate of #409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ToTextPlugin.kt