Fix crash for some android device when completeInitialize() in for below Android 31 Device #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palashpandya592
approved these changes
Jun 30, 2023
sowens-csd
reviewed
Jun 30, 2023
There was a problem hiding this comment.
Thanks for the patch. Which version of Android did you see the problem on and test this on? Also, would you mind having a look at PR 408 for me? I think this is a duplicate of that change. If this PR addresses the same issue then I will close 408 because I don't think it would fully fix the issue.
This was referenced Jun 30, 2023
|
Yes, @sowens-csd 408 also addresses the same issue but it uses try-catch so try-catch prevents using this feature so instead we can check based on version as my app reported this crash in almost all devices which is 11 or below 11. |
sowens-csd
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.