Prepare for Ruby 3.3 #914
Merged
Prepare for Ruby 3.3 #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
prepare-for-ruby-3-3
branch
from
e83a922 to
801284c
Compare
In Ruby 3.3, requiring readline does not load the real readline library but falls back to reline by default. This creates odd output when the terminal is not a real TTY and a prompt is used when getting input. Because pry uses a prompt, this makes the interactive debugging scenario fail. This change works around this issue by switching to irb. Irb will not use a prompt, possibly because the output is not a TTY. See #910. Also, see ruby/reline#616 for the resulting reline issue.
mvz
force-pushed
the
prepare-for-ruby-3-3
branch
from
801284c to
bdf5ede
Compare
See ruby/irb#623. The file was removed and the corresponding feature should be activated by setting :EVAL_HISTORY.
The default prompt format for irb changed in Ruby 3.3. Using the classic format instead ensures the same result is achieved in all Ruby versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prepare for upcoming Ruby 3.3
Details
This pull request consists of the following changes:
Motivation and Context
Mainly, #910.
How Has This Been Tested?
I ran the Cucumber scenario with the added gem in Ruby 3.3.0-preview3. I also tried just setting TERM=dumb as in rails/rails#48369 but that didn't work.
Types of changes
Checklist: