Test rails console with reline #48369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1. By removing the `--singleline` flag, IRB will use Reline by default. 2. By assigning `TERM=dumb`, Reline will skip east-asian width detection, which was what caused the test to hang. I need to stress that the east-asian width detection is not a bug but an improvement in Reline to help rendering east-asian characters correctly. Readline actually can't do this well. Please see @tompng's great explanation in ruby/irb#582 (comment) However, this detection should not happen when the terminal is running in PTY (usually used in test environment). The problem is that in Ruby we don't have a way to detect if the terminal is running in TTY or PTY. But by passing `TERM=dumb`, Reline will assume that the terminal is not capable of several advanced features, including this east-asian width detection.
st0012
force-pushed
the
test-rails-console-with-reline
branch
from
9c1ba7a to
cf45394
Compare
4 tasks
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Rails has been testing Rails console with
readlinefor a while. And recently due to the removal ofreadlinefrom default gems, it even needs to installreadline-extseparately (#48183).However, given
relinehas become IRB's default for a while and now receives frequent updates from a group of maintainers (myself included), I think it's worth running those tests withoutreadlineinstead.Detail
In addition to removing the
readline-extgem, this PR also has 2 changes:--singlelineflag, IRB will use Reline by default.TERM=dumb, which is a convention in terminal programs to indicate reduced/minimum feature set, Reline will skip east-asian width detection, which was what caused the test to hang.I need to stress that the east-asian width detection is not a bug but an
improvement in Reline to help rendering east-asian characters correctly.
Readline actually can't do this well. Please see @tompng's great explanation
in ruby/irb#582 (comment)
However, this detection should not happen when the terminal is running in
PTY (usually used in test environment). The problem is that in Ruby we
don't have a way to detect if the terminal is running in TTY or PTY.
But by passing
TERM=dumb, Reline will assume that the terminal is notcapable of several advanced features, including this east-asian width
detection.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]