Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag Pattern.UNICODE_CHARACTER_CLASS is not supported on Android #494

Closed
lsuski opened this issue Oct 8, 2018 · 7 comments · Fixed by #498
Closed

Flag Pattern.UNICODE_CHARACTER_CLASS is not supported on Android #494

lsuski opened this issue Oct 8, 2018 · 7 comments · Fixed by #498

Comments

@lsuski
Copy link
Contributor

lsuski commented Oct 8, 2018

Summary

#471 broke cucumber-android.
Flag Pattern.UNICODE_CHARACTER_CLASS is not supported on Android. It exists in Android and docs says that it has no effect on Android and can be passed but it is omitted in Pattern constructor and passing it throws exception.
@aslakhellesoy
Copy link
Contributor

Is there a way to detect android an conditionally pass it in?

@lsuski
Copy link
Contributor Author

lsuski commented Oct 8, 2018

https://stackoverflow.com/questions/4519556/how-to-determine-if-my-app-is-running-on-android

@lsuski
Copy link
Contributor Author

lsuski commented Oct 8, 2018

If these hacks are ok, I can submit PR

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Oct 8, 2018 •
edited
Loading

Does ServiceLoader work on Android? It'd be a bit neater to have Android and Cucumber-JVM provide cucumber expressions with a PatternCompiler service that strips out the unwanted/unsupported flags.

@lsuski
Copy link
Contributor Author

lsuski commented Oct 9, 2018

Yes, it works

@mpkorstanje
Copy link
Contributor

Let's use that solution then. It's less hacky and keeps the Android specific parts in Android.

@lsuski lsuski mentioned this issue Oct 10, 2018
Closed
lsuski added a commit that referenced this issue Oct 11, 2018
@lsuski
allow to provide custom PatternCompiler, fix #494
7004bdc
@lsuski lsuski mentioned this issue Oct 11, 2018
Merged
6 tasks
aslakhellesoy added a commit that referenced this issue Oct 11, 2018
@aslakhellesoy
Attribution. Closes #494.
dc4a754
@lock
Copy link

lock bot commented Oct 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 11, 2019
aslakhellesoy pushed a commit to cucumber/cucumber-expressions that referenced this issue Sep 20, 2021
@lsuski
allow to provide custom PatternCompiler, fix cucumber/common#494
9b085ac
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow to provide custom PatternCompiler cucumber/common
3 participants
@aslakhellesoy @lsuski @mpkorstanje