[gherkin-perl] Implement Gherkin on top of Cucumber::Messages #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the minimum supported Perl version to 5.14 (release date May 14, 2011) because that's the minimum supported by Cucumber::Messages.
…ckles
In Gherkin, the AstBuilder and the Pickle compiler, instantiate Cucumber::Messages
when constructing return values (the source, gherkin document and pickles, respectively).
Note that the earlier implementation used hashes (instead of object instances); the new
implementation uses methods to access slot values whereas the old implementation used
hash element access (`$table_row->{'cells'}` is therefore replaced by `$table_row->cells`).
Additionally, adjust the consumer (App::gherkin) to consume Cucumber::Message envelopes
instead of hashes: messages "know" how to serialize themselves to JSON (meaning that the
consumer won't need to cater for its own serialization).
ehuelsmann
added
library: gherkin
language: perl
💔 breaking change
aurelien-reeves
approved these changes
Sep 8, 2021
|
@aurelien-reeves Thanks for the review! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change the Gherkin implementation to use real Cucumber::Messages instead of hashes that look like them.
Details
Since Gherkin existed since way before Cucumber::Messages, its prior implementations didn't build upon them. With the recent implementation and release of Cucumber::Messages for Perl, now is the time to move the implementation over from the surrogates to the real thing.
Motivation and Context
With this change, the Perl implementation of Gherkin moves closer to its equivalents in other languages.
How Has This Been Tested?
The conformance tests.
Types of changes
Checklist: