Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gherkin-perl] Implement Gherkin on top of Cucumber::Messages #1735

Merged
merged 5 commits into from
Sep 8, 2021
Merged

[gherkin-perl] Implement Gherkin on top of Cucumber::Messages #1735

merged 5 commits into from
Sep 8, 2021

Commits on Sep 7, 2021

  1. [gherkin-perl] Declare dependency on Cucumber::Messages 

    Increase the minimum supported Perl version to 5.14 (release date
May 14, 2011) because that's the minimum supported by Cucumber::Messages.
    @ehuelsmann
    ehuelsmann committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    998f403 View commit details
    Browse the repository at this point in the history

  2. [gherkin-perl] Generate Cucumber::Messages instances based AST and Pi… 

    …ckles

In Gherkin, the AstBuilder and the Pickle compiler, instantiate Cucumber::Messages
when constructing return values (the source, gherkin document and pickles, respectively).

Note that the earlier implementation used hashes (instead of object instances); the new
implementation uses methods to access slot values whereas the old implementation used
hash element access (`$table_row->{'cells'}` is therefore replaced by `$table_row->cells`).

Additionally, adjust the consumer (App::gherkin) to consume Cucumber::Message envelopes
instead of hashes: messages "know" how to serialize themselves to JSON (meaning that the
consumer won't need to cater for its own serialization).
    @ehuelsmann
    ehuelsmann committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    53d627a View commit details
    Browse the repository at this point in the history

  3. [gherkin-perl] Update Gherkin documentation to mention Cucumber::Mess… 

    …ages
    @ehuelsmann
    ehuelsmann committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    7fd6558 View commit details
    Browse the repository at this point in the history

  4. [gherkin-perl] Fix reversed CI check in Makefile

    @ehuelsmann
    ehuelsmann committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    0ecb4df View commit details
    Browse the repository at this point in the history

  5. [gherkin] Update CHANGELOG.md

    @ehuelsmann
    ehuelsmann committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    02150d3 View commit details
    Browse the repository at this point in the history