Skip to content

Commit

Permalink
remove browser example and support for running in browser (#1508)
Browse files Browse the repository at this point in the history
* remove browser example

* re-add express typings, needed for publish server stub

* remove dist from npm packaging advice

* remove tsconfig.browser.json

* remove reference to browser support from README.md

* add changelog entry

* explain and qualify the remo

Co-authored-by: David Goss <david@davidgoss.co>
  • Loading branch information
charlierudolph and davidjgoss authored Dec 17, 2020
1 parent 5a5604d commit 3975db7
Show file tree
Hide file tree
Showing 19 changed files with 35 additions and 81,376 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
.nyc_output/
@rerun.txt
coverage/
dist/browser-example.js
html-formatter.html
lib/
messages.ndjson
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ notifications:
matrix:
include:
- node_js: "14"
script: "yarn test-coverage && yarn test-browser-example && yarn audit"
script: "yarn test-coverage && yarn audit"
after_success: "nyc report --reporter=text-lcov | coveralls"
- node_js: "12"
script: "yarn test"
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CO

### Removed

* Support for running Cucumber in web browsers has been removed ([#1508](https://github.com/cucumber/cucumber-js/pull/1508)). This feature was increasingly difficult to support and seldom used. Node.js will now be the only support runtime for Cucumber itself; of course as before you can still use tools like WebDriver and Puppeteer to instrument testing of browser-based software. See [the discussion in #1437](https://github.com/cucumber/cucumber-js/issues/1437) for more about why this change is happening.

### Fixed

* Wrong version in meta message [#1439](https://github.com/cucumber/cucumber-js/issues/1439) [#1442](https://github.com/cucumber/cucumber-js/pull/1442)
Expand Down
8 changes: 0 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@ See the `package.json` scripts section for how to run the tests.
* feature tests
* cucumber-js tests itself

## Test browser example locally

* Run `yarn build-browser-example`
* Run `node scripts/server.js`
* Visit `localhost:9797`.

The published browser example is only updated when releasing a new version.

## Internals

### Project Structure
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ written in plain language, they can be read by anyone on your team. Because they
read by anyone, you can use them to help improve communication, collaboration and trust on
your team.

Cucumber.js is the JavaScript implementation of Cucumber and runs on the [maintained Node.js versions](https://github.com/nodejs/Release) and *modern* web browsers.
Cucumber.js is the JavaScript implementation of Cucumber and runs on the [maintained Node.js versions](https://github.com/nodejs/Release).

## Try it now

Expand Down
1 change: 0 additions & 1 deletion dependency-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ ignoreErrors:
- eslint-plugin-standard # peer dependency of eslint-config-standard-with-typescript
- prettier # peer dependency of eslint-plugin-prettier
- ts-node # .mocharc.yml / cucumber.js
- tsify # package.json - scripts - build-browser-example, build-release

requiredModules:
files:
Expand Down
Loading

0 comments on commit 3975db7

Please sign in to comment.