-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove browser example and support for running in browser #1508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also delete:
tsconfig.browser.json
dist
from thefiles
list inpackage.json
Reference to "and modern browsers" in the readme- Link to the running browser example in the readme? Or maybe keep until we have something compelling to replace it with?
Also think we should have a changelog entry under breaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we record the rationale behind the decision to remove browser support somewhere public? I wonder if some people will be surprised or even disappointed and would need an explanation about this change.
In fact, while I agree to drop support for browser runs, I could use a good write up of that decision myself. I still think we're closing a door to a feature without total assurance that it is not used much.
The upcoming disappearance of https://cucumber.github.io/cucumber-js/ is a bit of a shame, too (I guess it could be done server-side though).
Are we taking https://cucumber.github.io/cucumber-js/ down, btw? |
Good question. It does give a nice demo for new starters. Even with only Node.js supported I think we could make something similar happen with RunKit or some other server-side thing. Just a question of whether we leave it up in the meantime. I don't feel strongly either way. |
I suppose we can leave it at the moment, with the last supported version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to go!
I wish this would have stayed or restructured as an optional feature. I think it should be improved, not removed. |
Hi @jbpros, If the answer is yes, do you have any suggestion to run Cucumber testing on the browser? In my case, I need Cucumber testing for FE app and it should be running on the browser due to my FE library expect a couple of Thanks in advance.
|
@Taewa we removed the ability for cucumber-js itself (the test runner) to run in the browser, but you can absolutely use it to test browser-based software with webdriver, puppeteer, playwright etc as ever. |
Hi @davidjgoss thanks for the quick response. I am aware of webdriver, puppeteer, playwright and I used to use WDIO. Running e2e test fits well with these e2e tools. Like opening import { binding, given, then, when } from 'cucumber-tsflow';
import { fixture, html } from '@open-wc/testing';
import '../../src/SimpleGreeting.js';
@binding()
export class SimpleGreetingSteps {
private element;
@given('There is SimpleGreeting component')
public async initComponent() {
this.element = await fixture(
html`
<simple-greeting></simple-greeting>
`,
);
}
@when(/Start rendering/)
public renderComponent() {
this.element.render();
}
@then(/Name is rendered/)
public assertResult() {
// assert with mocha/chai
expect(...)
}
} (I know I am using 3rd party cucumber plugin 'cucumber-tsflow' but this is what I want to run briefly on the browser) In the above example, However, I think it might be possible with Karma by running a browser. Just I don't know how to execute If you know any other solution or suggestion or please correct me if my knowledge is wrong. |
@davidjgoss To add up, using Karma is an optional. My main intention is to use Cucumber (BDD) testing for individual web component.
As you can see there is no "customer login" pre-step. |
@Taewa i am looking for pretty much the same thing - did you get anywhere? PS: I got here digging through the docs and the issue tracker, |
Hi @sijakret
|
Also removed
build release
which produced a browserified version of cucumber-jsCloses #1437