Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with version cucumber@1.2.1 commit - StackTrace getFileName of undefined #610

Closed
gkushang opened this issue Jul 10, 2016 · 4 comments

Comments

@gkushang
Copy link

We are seeing below issue with the recent release 1.2.1 and possibly with this commit - 1d02c6a.

Below is stackTrace,

TypeError: Cannot call method 'getFileName' of undefined
    at isFrameInCucumber (.../node_modules/cucumber/lib/cucumber/runtime/stack_trace_filter.js:9:24)
    at Array.0 (.../node_modules/cucumber/lib/cucumber/runtime/stack_trace_filter.js:15:9)
    at TraceModifier._modify (...node_modules/stack-chain/stack-chain.js:44:32)
    at Function.prepareStackTrace (.../node_modules/cucumber/node_modules/stack-chain/stack-chain.js:119:25)
    at promise.Promise.resolve_ (eval at <anonymous> (.../node_modules/selenium-webdriver/lib/goog/base.js:1094:19), <anonymous>:440:36)
    at eval (eval at <anonymous> (.../node_modules/selenium-webdriver/lib/goog/base.js:1094:19), <anonymous>:371:12)
    at reject (eval at <anonymous> (.../node_modules/selenium-webdriver/lib/goog/base.js:1094:19), <anonymous>:709:5)
    at promise.ControlFlow.runInFrame_ (eval at <anonymous> (.../node_modules/selenium-webdriver/lib/goog/base.js:1094:19), <anonymous>:1917:5)
    at goog.defineClass.notify (eval at <anonymous> (.../node_modules/selenium-webdriver/lib/goog/base.js:1094:19), <anonymous>:2448:25)
   ...

Previous releases works fine.

@gkushang
Copy link
Author

Below is our observations:

1. `this.Then` step has chai-as-promised assertions

2. Assertion fails. e.g. 

var chai = require('chai');
var chaiAsPromise = require('chai-as-promised');
var should = chai.should();

chai.use(chaiAsPromise);

//THEN STEP
    seleniumPage.getErrorMessage().should.eventually.to
      .equal('somethingNotExpectedString', 'failure message')
      .notify(function(err) {
        if (err) {
          callback(err);
        }
      });

3. Above error is reproducible when next step (after `this.Then`) executes, it can be either @After or @anotherGWT

This seems to be breaking change in recent version

HTH

Thanks,
Kushang

@charlierudolph
Copy link
Member

I believe this was fixed in #609. I'll try to release 1.2.2 today

@gkushang
Copy link
Author

gkushang commented Aug 5, 2016

Sounds great, thanks! Will reopen the issue if it still exists in upcoming version.

Kushang

@gkushang gkushang closed this as completed Aug 5, 2016
Cruikshanks added a commit to DEFRA/data-returns-acceptance-tests that referenced this issue Aug 12, 2016
xolvio/chimp#441
cucumber/cucumber-js#610

The latest version of Chimp uses Cucumber-js v1.2.1 which appears to have an issue when any unexpected error is thrown (e.g. element not found).

It looks like cucumber-js have fixed this, but until Chimp updates to the lastest version am downgrading Chimp to a version that uses Cucumber-js v1.2.0
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants