Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Reason feature for skipped and pending steps #987

Closed
wants to merge 0 commits into from

Conversation

jshifflet
Copy link
Contributor

@charlierudolph this is a POC for the reason feature.

Reasons can be used with skipped and pending step return values.

Still some work on formatters and a lot of cleanup to go.

Let me know if this is how you imagined this feature working.

This is not ready to merge yet.

Thanks.

@aslakhellesoy
Copy link
Contributor

Can anyone provide a link to where this feature has been discussed?

We’re going to put more effort into making the various Cucumber implementations consistent, and I’d like to understand the motivation for this proposal as well as the implications for the event protocol and other implementations.

@charlierudolph
Copy link
Member

@aslakhellesoy. It came from #912. Currently skipped scenarios are not outputted anywhere. Changing that I think is what needs to happen first. Then I was thinking it would be nice to give the reason it was skipped so the user doesn't need to go look in the code.

@jshifflet
Copy link
Contributor Author

@aslakhellesoy and @charlierudolph sorry for the misunderstanding.

Is there an issue or any details about how "skipped" steps should show in the various formatters?

@lock
Copy link

lock bot commented Dec 19, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants