[Core, JUnit, Android] Add the ambiguous result type. #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Took the opportunity to add a bit of consistency to the the AndroidInstrumentationReporter, JUnitReporter and TestNgReporter. |
Report ambiguous steps as a separate result type, instead of reporting them as failed. The new ambiguous result type will make the exit code non-zero (the same as the failed result type currently used when ambiguous step matches are found).
The AndroidInstrumentationReporter, JUnitReporter and TestNgReporter have some subtle style difference between. This made the code base a bit harder to understand. Using a switch-case-default-throws pattern makes it consistent and will make errors explicit when more states are added.
mpkorstanje
force-pushed
the
ambiguous-result
branch
from
2c16567 to
fba93e7
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Report ambiguous steps as a separate result type, instead of reporting them as failed.
Details
Report ambiguous steps as a separate result type, instead of reporting them as failed. The new ambiguous result type will make the exit code non-zero (the same as the failed result type currently used when ambiguous step matches are found).
Motivation and Context
Cucumber-JS already has a separate result type for ambiguous step matches. In Cucumber-Ruby there is an initiative to introduce them
How Has This Been Tested?
The automated test suite has been updated to verify this behaviour.
I have manually introduces ambiguous step matches in the java-calculator example to manually check the implementation.
Types of changes
Checklist: