Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Running empty Pickles should yield the result undefined. #1274

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

brasmusson
Copy link
Contributor

Summary

Running empty Pickles should yield the result undefined.

Details

Gherkin v5 does create empty Pickles for Scenarios with no steps. Running these empty Pickles should yield the result undefined, and no test steps should be executed.

Motivation and Context

See cucumber/cucumber#249 and cucumber/cucumber-ruby-core#144 (comment) for background

How Has This Been Tested?

The automated test suite has been updated to verify this behavior.

I have also manually/locally added an empty scenario to the Java calculator example to check that it indeed yielded an undefined scenario in the summary count.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Gherkin v5 does create empty Pickles for Scenarios with no steps.
Running these empty Pickles should yield the result undefined, and
no test steps should be executed.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 81.312% when pulling 024871e on empty-pickles-handling into 72f975a on master.

@mpkorstanje mpkorstanje merged commit fc587f6 into master Oct 26, 2017
@mpkorstanje mpkorstanje deleted the empty-pickles-handling branch October 26, 2017 21:23
@lock
Copy link

lock bot commented Oct 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants