List all not ok scenarios in the summary #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
brasmusson
force-pushed
the
list-all-not-ok-scenarios
branch
from
1fec5e4 to
4424a0c
Compare
Currently only failed scenarios are listed in the summary, but also scenarios of other result types can force the exit code to be non-zero. Therefore list the scenarios of all result type the each would have made the exit code non-zero.
Use the Cucumber::Core::Test::Result::TYPES and Cucumber::Core::Report::Summary to reduce the duplication between ConsoleCounts and Cucumber-Ruby-Core.
brasmusson
force-pushed
the
list-all-not-ok-scenarios
branch
from
4424a0c to
c5453f7
Compare
This was referenced Jul 16, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
List all not ok scenarios in the summary.
Details
Currently only failed scenarios are listed in the summary, but also scenarios of other result types can force the exit code to be non-zero (currently
pendingandundefinedscenarios - in strict mode). Therefore list the scenarios of all result type the each would have made the exit code non-zero.Also reduce the duplication between Cucumber-Ruby and Cucumber-Ruby-Core by using
Cucumber::Core::Report::Summary#ok?to calculate the exit codeCucumber::Core::Test::Result::TYPESandCucumber::Core::Report::SummaryinConsoleCountsThese changes also paves the way for the introduction of
ambiguousresults andflakyresults.Depends on cucumber/cucumber-ruby-core#140.
How Has This Been Tested?
Existing feature files has been modified to verify the changed listing of scenarios in the summary.
Types of changes
Checklist: