Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disable_autorun #30

Merged
merged 3 commits into from
May 4, 2022
Merged

Remove disable_autorun #30

merged 3 commits into from
May 4, 2022

Conversation

aurelien-reeves
Copy link
Contributor

Fixes #26

olleolleolle
olleolleolle approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean removal!

aurelien-reeves and others added 2 commits May 4, 2022 15:47
@aurelien-reeves
Update changelog
5dc2c3a
@mattwynne @aurelien-reeves
Remove scenarios that were only testing the disable_autorun feature
8bb4cb1 
Co-authored-by: Aurelien Reeves <aurelien.reeves@smartbear.com>
@mattwynne mattwynne merged commit d36742e into main May 4, 2022
@mattwynne mattwynne deleted the remove-disable_autorun branch May 4, 2022 14:49
@hamxashahid
Copy link

This is a breaking change, the cucumber-ruby gem might not use this but the cucumber-rails gem does

https://github.com/cucumber/cucumber-rails/blob/main/lib/cucumber/rails.rb#L32

mattwynne added a commit that referenced this pull request May 10, 2022
@mattwynne
Revert "Remove disable_autorun (#30)"
c4e4666 
This reverts commit d36742e.

Ref #26
aurelien-reeves added a commit that referenced this pull request May 11, 2022
@mattwynne @aurelien-reeves
Revert "Remove disable_autorun (#30)" (#33)
3db4de5 
* Revert "Remove disable_autorun (#30)"

This reverts commit d36742e.

Ref #26

Co-authored-by: Aurélien Reeves <aurelien.reeves@smartbear.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@mattwynne mattwynne Awaiting requested review from mattwynne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove disable_autorun feature
4 participants
@aurelien-reeves @hamxashahid @olleolleolle @mattwynne