Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove disable_autorun (#30)" #33

Merged
merged 6 commits into from
May 11, 2022

Conversation

mattwynne
Copy link
Member

@mattwynne mattwynne commented May 10, 2022

🤔 What's changed?

  • revert commit d36742e.
  • update CHANGELOG

⚡️ What's your motivation?

It seems that in #26 we were a bit premature, since this method is still being used in cucumber-rails.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

I'm proposing we merge this and release it as v1.1.0.

The alternative, perhaps braver move would be to release cucumber-rails with the call to this method removed, and see if anybody complains. I really have no idea whether this autorun stuff will still be a problem anymore. I haven't used Rails in years and don't have enough context.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@mattwynne mattwynne requested a review from aurelien-reeves May 10, 2022 23:03
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@aurelien-reeves aurelien-reeves merged commit 3db4de5 into main May 11, 2022
@aurelien-reeves aurelien-reeves deleted the add-disable_autorun_back-again branch May 11, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants