Revert "Remove disable_autorun (#30)" #33
Merged
+71
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
⚡️ What's your motivation?
It seems that in #26 we were a bit premature, since this method is still being used in cucumber-rails.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I'm proposing we merge this and release it as
v1.1.0
.The alternative, perhaps braver move would be to release
cucumber-rails
with the call to this method removed, and see if anybody complains. I really have no idea whether thisautorun
stuff will still be a problem anymore. I haven't used Rails in years and don't have enough context.📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.