Skip to content

Commit

Permalink
[Dependencies] Upgrade React 16 to React 17 (#553)
Browse files Browse the repository at this point in the history
* Bump react packages (and react-slick)

* Undo strict mode, for now

* Add testing-library POC usage for carousel test functionality (otherwise breaking without proper setup testing library provides)

* Fix bizarre typescript error re: react-slick

* Restore enzyme compat with OSS 17 adapter

* Restore enzyme compat with OSS 17 adapter pt. 2

* Add additional carousel cards (for more realistic test), remove enzyme-16 adapter

* Update tests

* Bump peer deps to 17

* Bump react

* Bump types

* Update types

* Update snapshots to reduce artifacts
  • Loading branch information
michaeljaltamirano authored Dec 27, 2021
1 parent 42564ef commit 3a83f88
Show file tree
Hide file tree
Showing 5 changed files with 1,383 additions and 50 deletions.
3 changes: 2 additions & 1 deletion .storybook/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ const config = {
},
reactOptions: {
fastRefresh: true,
strictMode: true,
// TODO: Does not play well with emotion theming
// strictMode: true,
},
};

Expand Down
14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@
"@types/lodash.round": "^4.0.6",
"@types/lodash.throttle": "^4.1.6",
"@types/lodash.uniqueid": "^4.0.6",
"@types/react": "^16.9.49",
"@types/react-dom": "^16.9.4",
"@types/react": "^17.0.38",
"@types/react-dom": "^17.0.11",
"@types/react-slick": "^0.23.4",
"@types/react-transition-group": "^4.4.0",
"@types/tinycolor2": "^1.4.2",
Expand Down Expand Up @@ -150,7 +150,7 @@
"jest-junit": "^13.0.0",
"lint-staged": "^12.1.2",
"prettier": "2.5.1",
"react-is": "^16.13.1",
"react-is": "^17.0.1",
"regenerator-runtime": "^0.13.7",
"rimraf": "^3.0.2",
"rollup": "^2.26.11",
Expand All @@ -170,8 +170,8 @@
"lodash.throttle": "^4.1.1",
"lodash.uniqueid": "^4.0.1",
"prop-types": "^15.7.2",
"react": "^16.14.0",
"react-dom": "^16.14.0",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-slick": "^0.28.1",
"react-toggle-button": "^2.2.0",
"react-transition-group": "^4.4.1",
Expand All @@ -180,8 +180,8 @@
"peerDependencies": {
"@emotion/react": "11.7.1",
"@emotion/styled": "11.6.0",
"react": "^16.14.0",
"react-dom": "^16.14.0"
"react": "^17.0.2",
"react-dom": "^17.0.2"
},
"husky": {
"hooks": {
Expand Down
Loading

0 comments on commit 3a83f88

Please sign in to comment.