[Dependencies] Upgrade React 16 to React 17 #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ise breaking without proper setup testing library provides)
| const tree = renderer | ||
| .create(<Carousel numCardsVisible={1}>{cards}</Carousel>) | ||
| .toJSON(); | ||
| const { container } = render( |
There was a problem hiding this comment.
TODO: Make the assertions in this test more meaningful. The snapshot doesn't really do much.
|
| @@ -1,16 +1,291 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`<Carousel /> UI snapshots renders with bottom right aligned arrows 1`] = ` | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Need to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What & Why
This PR upgrades
reactfrom 16 to 17. You can read the official note on the major version change here, but unlike previous breaking changes, this one is mostly to prime futurereactreleases. As such, the diff is minimal: some dependency version changes, a modifiedjesttest, a couple new TypeScript explicit return types, but otherwise there's no change in behavior.Other
peerDependenciesdo not includereact 16anymore.