Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using npm ci #2350

Merged
merged 4 commits into from
Oct 29, 2020
Merged

Using npm ci #2350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d35f472
Added usage npm ci
ActiveChooN Oct 27, 2020
0baeee7
Added CHANGELOG
ActiveChooN Oct 28, 2020
b4b1971
Fixed README
ActiveChooN Oct 28, 2020
0d0af4b
Merge branch 'develop' into dk/ui-build-ci
ActiveChooN Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Updated `docker-compose` file version from `2.3` to `3.3`(<https://github.com/openvinotoolkit/cvat/pull/2235>)
- Added auto inference of url schema from host in CLI, if provided (<https://github.com/openvinotoolkit/cvat/pull/2240>)
- Track frames in skips between annotation is presented in MOT and MOTS formats are marked `outside` (<https://github.com/openvinotoolkit/cvat/pull/2198>)
- UI packages installation with `npm ci` instead of `npm install` (<https://github.com/openvinotoolkit/cvat/pull/2350>)

### Deprecated

Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ patches and features.
- Install npm packages for UI and start UI debug server (run the following command from CVAT root directory):

```sh
npm install && \
cd cvat-core && npm install && \
cd ../cvat-ui && npm install && npm start
npm ci && \
cd cvat-core && npm ci && \
cd ../cvat-ui && npm ci && npm start
```

> Note for Mac users
Expand Down
8 changes: 4 additions & 4 deletions Dockerfile.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,19 @@ RUN npm config set loglevel info

# Install cvat-data dependencies
WORKDIR /tmp/cvat-data/
RUN npm install
RUN npm ci

# Install cvat-core dependencies
WORKDIR /tmp/cvat-core/
RUN npm install
RUN npm ci

# Install cvat-canvas dependencies
WORKDIR /tmp/cvat-canvas/
RUN npm install
RUN npm ci

# Install cvat-ui dependencies
WORKDIR /tmp/cvat-ui/
RUN npm install
RUN npm ci

# Build source code
COPY cvat-data/ /tmp/cvat-data/
Expand Down
2 changes: 1 addition & 1 deletion cvat-core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ If you make changes in this package, please do following:
- Dependencies installation

```bash
npm install
npm ci
```

- Building the module from sources in the `dist` directory:
Expand Down
2 changes: 1 addition & 1 deletion cvat-ui/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ you also need to do `npm install` to update `package-lock.json`
- Installing dependencies:

```bash
cd ../cvat-core && npm install && cd - && npm install
cd ../cvat-core && npm ci && cd - && npm ci
```

- Running development UI server with autorebuild on change
Expand Down
1 change: 0 additions & 1 deletion cvat-ui/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.