Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webhook creation/filtering with invalid org #5707

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

Extracted from #5662

If a project webhook was created and an org was specified, the org from the request could be assigned to the webhook, while the project could be in another org or outside an org. Then, project events could not be delivered to the webhooks. This PR fixes this problem by ignoring the org specified in the request in favor of the org specified in the project.

  • Fixed a possible bug in project/org handling for webhooks
  • Added a test

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Copy link
Contributor

@sizov-kirill sizov-kirill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 2749dc4 into develop Mar 16, 2023
@nmanovic nmanovic deleted the zm/handle-mismatching-project-org branch March 16, 2023 12:47
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants