Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cached frames indication #6586

Merged
merged 11 commits into from
Aug 11, 2023
Merged

Added cached frames indication #6586

merged 11 commits into from
Aug 11, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jul 30, 2023

Depends on #6585

Motivation and context

Resolved #8

Decoded range is red:
image

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested a review from azhavoro as a code owner July 30, 2023 10:24
@bsekachev bsekachev changed the title [WIP] [Depended] Major refactoring of decoding module, added cached frames indication [Depended] Major refactoring of decoding module, added cached frames indication Aug 10, 2023
@bsekachev bsekachev changed the title [Depended] Major refactoring of decoding module, added cached frames indication Major refactoring of decoding module, added cached frames indication Aug 10, 2023
@bsekachev bsekachev changed the title Major refactoring of decoding module, added cached frames indication Added cached frames indication Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #6586 (ab6626a) into develop (c68cb07) will increase coverage by 0.06%.
Report is 23 commits behind head on develop.
The diff coverage is 69.11%.

@@             Coverage Diff             @@
##           develop    #6586      +/-   ##
===========================================
+ Coverage    81.25%   81.32%   +0.06%     
===========================================
  Files          368      366       -2     
  Lines        39813    39664     -149     
  Branches      3557     3504      -53     
===========================================
- Hits         32351    32256      -95     
+ Misses        7462     7408      -54     
Components Coverage Δ
cvat-ui 75.07% <72.13%> (+0.13%) ⬆️
cvat-server 86.76% <11.76%> (-0.04%) ⬇️

@klakhov
Copy link
Contributor

klakhov commented Aug 11, 2023

I have an error in the console after running yarn run start:cvat-ui:
image

It seems decoded range is not updated(under blue dot) when I jump somewhere(red line is shown only after I change frame second time), is that expected?
player

Why decoded block is red? Isn't it too bright and attention-grabbing? Why not default antd blue color?
image

@bsekachev
Copy link
Member Author

I have an error in the console after running yarn run start:cvat-ui:

Errors not relevant, as discussed, found on outdated code.

@bsekachev bsekachev merged commit 9a01ece into develop Aug 11, 2023
14 checks passed
@bsekachev bsekachev deleted the bs/decode_refactoring branch August 11, 2023 08:38
@SpecLad SpecLad mentioned this pull request Aug 11, 2023
SpecLad added a commit that referenced this pull request Aug 11, 2023
## \[2.6.0\] - 2023-08-11

### Added

- \[SDK\] Introduced the `DeferredTqdmProgressReporter` class,
  which avoids the glitchy output seen with the `TqdmProgressReporter` under certain circumstances
  (<#6556>)
- \[SDK, CLI\] Added the `cvat_sdk.auto_annotation`
  module, providing functionality to automatically annotate tasks
  by executing a user-provided function on the local machine.
  A corresponding CLI command (`auto-annotate`) is also available.
  Some predefined functions using torchvision are also available.
  (<#6483>,
  <#6649>)
- Included an indication for cached frames in the interface
  (<#6586>)

### Changed

- Raised the default guide assets limitations to 30 assets,
  with a maximum size of 10MB each
  (<#6575>)
- \[SDK\] Custom `ProgressReporter` implementations should now override `start2` instead of `start`
  The old implementation is still supported.
  (<#6556>)
- Improved memory optimization and code in the decoding module (<#6585>)

### Removed

- Removed the YOLOv5 serverless function
  (<#6618>)

### Fixed

- Corrected an issue where the prebuilt FFmpeg bundled in PyAV
  was being used instead of the custom build.
- Fixed the filename for labels in the CamVid format (<#6600>)
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

Depends on cvat-ai#6585

### Motivation and context
Resolved #8

Decoded range is red:
<img width="537" alt="image"
src="https://github.com/opencv/cvat/assets/40690378/686c4016-ef09-4ec9-8815-2c88f820f2d6">

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video/Image loading status as on youtube
2 participants