Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filename for label in CamVid format #6600

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Fix filename for label in CamVid format #6600

merged 4 commits into from
Aug 10, 2023

Conversation

kolonist-minjun
Copy link
Contributor

@kolonist-minjun kolonist-minjun commented Aug 2, 2023

In the previous description of the CamVid format, the filename for the label was 'labelmap.txt', but the correct filename is 'label_colors.txt'.

Therefore, in this proposal, I fixed 'labelmap.txt' to 'label_colors.txt'. Also, I added the comment about 'color (RGB) value is not necessary'.

Motivation and context

#6599 After aligning the folder structure according to the CamVid format specified in the official documentation, I noticed that the import process was not working. Upon investigation, I found that the correct label filename should be 'label_colors.txt' instead of 'labelmap.txt' for successful import. To rectify the misinformation in the official documentation, I have created an issue and submitted a pull request to address this issue.

How has this been tested?

I tested that the import process was not successful when the label filename was set as 'labelmap.txt', but when I changed it to 'label_colors.txt' and attempted the import again, it was successful.

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

In the previous description of the CamVid format, the filename for the label was 'labelmap.txt', but the correct filename is 'label_colors.txt'.

Therefore, in this proposal, I fixed 'labelmap.txt' to 'label_colors.txt'. Also, I added the comment about 'color (RGB) value is not necessary'.
Added a description about 'Fix filename for label in CamVid format'
@zhiltsov-max
Copy link
Contributor

Hi, thanks for your contribution! Please address the comments before the PR can be merged.

@zhiltsov-max zhiltsov-max linked an issue Aug 9, 2023 that may be closed by this pull request
2 tasks
…color information)

Add example code about label_colors.txt without color information.

->
# label_colors.txt (without color value type)
# if you do not manually set the color for labels, it will be set automatically:
# label
Void
Animal
Archway
Bicyclist
Bridge
@zhiltsov-max zhiltsov-max merged commit acfa87a into cvat-ai:develop Aug 10, 2023
11 checks passed
@SpecLad SpecLad mentioned this pull request Aug 11, 2023
SpecLad added a commit that referenced this pull request Aug 11, 2023
## \[2.6.0\] - 2023-08-11

### Added

- \[SDK\] Introduced the `DeferredTqdmProgressReporter` class,
  which avoids the glitchy output seen with the `TqdmProgressReporter` under certain circumstances
  (<#6556>)
- \[SDK, CLI\] Added the `cvat_sdk.auto_annotation`
  module, providing functionality to automatically annotate tasks
  by executing a user-provided function on the local machine.
  A corresponding CLI command (`auto-annotate`) is also available.
  Some predefined functions using torchvision are also available.
  (<#6483>,
  <#6649>)
- Included an indication for cached frames in the interface
  (<#6586>)

### Changed

- Raised the default guide assets limitations to 30 assets,
  with a maximum size of 10MB each
  (<#6575>)
- \[SDK\] Custom `ProgressReporter` implementations should now override `start2` instead of `start`
  The old implementation is still supported.
  (<#6556>)
- Improved memory optimization and code in the decoding module (<#6585>)

### Removed

- Removed the YOLOv5 serverless function
  (<#6618>)

### Fixed

- Corrected an issue where the prebuilt FFmpeg bundled in PyAV
  was being used instead of the custom build.
- Fixed the filename for labels in the CamVid format (<#6600>)
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
Fixed the filename for the label map file in CamVid format from 'labelmap.txt' to 'label_colors.txt'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid filename for label in CamVid format
2 participants