-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset source/target storage if related cloud storage has been deleted #6801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Marishka17 , don't forget to add a line into CHANGELOG.md |
@Marishka17 , Why we have cloud_storage_id here https://github.com/opencv/cvat/blob/8c8cf70b1d392ad6b8ec9288fe4423cf85762647/cvat/apps/engine/models.py#L1151? Why don't we have a Foreign Key? |
Marishka17
changed the title
Update target/source storages after deleting cloud storage
[WIP] Update target/source storages after deleting cloud storage
Sep 15, 2023
Marishka17
changed the title
[WIP] Update target/source storages after deleting cloud storage
Reset source/target storage if related cloud storage has been deleted
Nov 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6801 +/- ##
===========================================
+ Coverage 81.44% 81.46% +0.02%
===========================================
Files 364 364
Lines 39882 39877 -5
Branches 3702 3702
===========================================
+ Hits 32482 32486 +4
+ Misses 7400 7391 -9
|
SpecLad
requested changes
Nov 17, 2023
cvat/apps/engine/migrations/0076_remove_storage_cloud_storage_id_and_more.py
Outdated
Show resolved
Hide resolved
Marishka17
changed the title
Reset source/target storage if related cloud storage has been deleted
[WIP] Reset source/target storage if related cloud storage has been deleted
Nov 21, 2023
SpecLad
reviewed
Nov 21, 2023
cvat/apps/engine/migrations/0076_remove_storage_cloud_storage_id_and_more.py
Outdated
Show resolved
Hide resolved
Marishka17
changed the title
[WIP] Reset source/target storage if related cloud storage has been deleted
Reset source/target storage if related cloud storage has been deleted
Nov 21, 2023
Marishka17
changed the title
Reset source/target storage if related cloud storage has been deleted
[Do not merge] Reset source/target storage if related cloud storage has been deleted
Nov 21, 2023
Marishka17
changed the title
[Do not merge] Reset source/target storage if related cloud storage has been deleted
Reset source/target storage if related cloud storage has been deleted
Nov 22, 2023
SpecLad
reviewed
Nov 22, 2023
SpecLad
approved these changes
Nov 23, 2023
SpecLad
pushed a commit
that referenced
this pull request
Dec 6, 2023
This PR contains REST API tests for #6801
Merged
amjadsaadeh
pushed a commit
to amjadsaadeh/cvat
that referenced
this pull request
Dec 14, 2023
This PR contains REST API tests for cvat-ai#6801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Resolved #6781
How has this been tested?
Manually
Checklist
develop
branch- [ ] I have updated the documentation accordingly- [ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.