Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset source/target storage if related cloud storage has been deleted #6801

Merged
merged 17 commits into from
Nov 23, 2023

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Sep 4, 2023

Motivation and context

Resolved #6781

How has this been tested?

Manually

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
    - [ ] I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
    - [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@nmanovic
Copy link
Contributor

nmanovic commented Sep 4, 2023

@Marishka17 , don't forget to add a line into CHANGELOG.md

@nmanovic
Copy link
Contributor

nmanovic commented Sep 4, 2023

@Marishka17 , Why we have cloud_storage_id here https://github.com/opencv/cvat/blob/8c8cf70b1d392ad6b8ec9288fe4423cf85762647/cvat/apps/engine/models.py#L1151? Why don't we have a Foreign Key?

@Marishka17 Marishka17 changed the title Update target/source storages after deleting cloud storage [WIP] Update target/source storages after deleting cloud storage Sep 15, 2023
@Marishka17 Marishka17 changed the title [WIP] Update target/source storages after deleting cloud storage Reset source/target storage if related cloud storage has been deleted Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #6801 (2616210) into develop (791ba7f) will increase coverage by 0.02%.
The diff coverage is 43.75%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6801      +/-   ##
===========================================
+ Coverage    81.44%   81.46%   +0.02%     
===========================================
  Files          364      364              
  Lines        39882    39877       -5     
  Branches      3702     3702              
===========================================
+ Hits         32482    32486       +4     
+ Misses        7400     7391       -9     
Components Coverage Δ
cvat-ui 75.54% <ø> (+0.04%) ⬆️
cvat-server 87.02% <43.75%> (+<0.01%) ⬆️

@Marishka17
Copy link
Contributor Author

@azhavoro or @SpecLad, Could you please take a look at the PR?

cvat/apps/engine/serializers.py Outdated Show resolved Hide resolved
cvat/apps/engine/serializers.py Outdated Show resolved Hide resolved
cvat/apps/engine/serializers.py Outdated Show resolved Hide resolved
cvat/apps/engine/location.py Outdated Show resolved Hide resolved
cvat/apps/engine/serializers.py Show resolved Hide resolved
@Marishka17 Marishka17 changed the title Reset source/target storage if related cloud storage has been deleted [WIP] Reset source/target storage if related cloud storage has been deleted Nov 21, 2023
@Marishka17 Marishka17 changed the title [WIP] Reset source/target storage if related cloud storage has been deleted Reset source/target storage if related cloud storage has been deleted Nov 21, 2023
@Marishka17 Marishka17 changed the title Reset source/target storage if related cloud storage has been deleted [Do not merge] Reset source/target storage if related cloud storage has been deleted Nov 21, 2023
@Marishka17 Marishka17 changed the title [Do not merge] Reset source/target storage if related cloud storage has been deleted Reset source/target storage if related cloud storage has been deleted Nov 22, 2023
cvat/apps/engine/serializers.py Outdated Show resolved Hide resolved
cvat/apps/engine/serializers.py Show resolved Hide resolved
cvat/apps/engine/serializers.py Outdated Show resolved Hide resolved
cvat/apps/engine/serializers.py Outdated Show resolved Hide resolved
@SpecLad SpecLad merged commit 92239d2 into develop Nov 23, 2023
34 checks passed
@SpecLad SpecLad deleted the mk/fix-cs-deletion-handling branch November 23, 2023 13:25
@Marishka17 Marishka17 mentioned this pull request Dec 4, 2023
4 tasks
SpecLad pushed a commit that referenced this pull request Dec 6, 2023
This PR contains REST API tests for
#6801
@cvat-bot cvat-bot bot mentioned this pull request Dec 11, 2023
amjadsaadeh pushed a commit to amjadsaadeh/cvat that referenced this pull request Dec 14, 2023
This PR contains REST API tests for
cvat-ai#6801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudStorage matching query doesn't exist
3 participants