Add tests for 6781 issue #7217
Merged
Add tests for 6781 issue #7217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7217 +/- ##
===========================================
+ Coverage 81.48% 81.54% +0.05%
===========================================
Files 365 365
Lines 39918 39261 -657
Branches 3703 3631 -72
===========================================
- Hits 32526 32014 -512
+ Misses 7392 7247 -145
|
SpecLad
reviewed
Dec 5, 2023
tests/python/rest_api/test_tasks.py
Outdated
| DATASET_FORMAT = "CVAT for images 1.1" | ||
|
|
||
| def _test_export_task( | ||
| self, username: str, tid: int, dataset_format: Optional[str] = None, **kwargs |
There was a problem hiding this comment.
Suggested change
| self, username: str, tid: int, dataset_format: Optional[str] = None, **kwargs | |
| self, username: str, tid: int, *, format: Optional[str] = None, **kwargs |
There doesn't seem to be much reason to change format to dataset_format.
tests/python/rest_api/test_tasks.py
Outdated
| response = export_dataset( | ||
| api_client.tasks_api.retrieve_dataset_endpoint, | ||
| id=task["id"], | ||
| format=self.DATASET_FORMAT, |
There was a problem hiding this comment.
Isn't this redundant? self.DATASET_FORMAT is supposed to be the default.
SpecLad
approved these changes
Dec 6, 2023
2 tasks
amjadsaadeh
pushed a commit
to amjadsaadeh/cvat
that referenced
this pull request
Dec 14, 2023
This PR contains REST API tests for cvat-ai#6801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This PR contains REST API tests for #6801
How has this been tested?
Checklist
developbranch- [ ] I have created a changelog fragment- [ ] I have updated the documentation accordingly- [ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.