-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed timestamp alignment on quality page #8106
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent update refines the layout and aesthetics of the quality report controls in the CVAT application's quality page. This includes styling adjustments in the components and reorganization of the report controls with Ant Design's Changes
Sequence Diagram(s)No sequence diagram required as changes pertain to UI layout and styling, without altering the fundamental control flow. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- changelog.d/20240702_124739_klakhov_fix_quality_timestamp.md (1 hunks)
- cvat-ui/src/components/analytics-page/styles.scss (3 hunks)
- cvat-ui/src/components/analytics-page/task-quality/mean-quality.tsx (2 hunks)
Files skipped from review due to trivial changes (1)
- changelog.d/20240702_124739_klakhov_fix_quality_timestamp.md
Additional comments not posted (19)
cvat-ui/src/components/analytics-page/styles.scss (2)
96-97
: LGTM!The added CSS rule ensures that the margin at the end of inline elements is set to 0, which fixes the alignment issue.
132-132
: LGTM!The adjusted padding uses a variable for consistency and improves the visual alignment of the quality settings switch.
cvat-ui/src/components/analytics-page/task-quality/mean-quality.tsx (17)
8-8
: LGTM!The imported
Col
andRow
components are necessary for the layout reorganization.
60-60
: LGTM!The added
Row
component improves the visual alignment of the quality report controls.
61-61
: LGTM!The added
Col
component inside theRow
component contributes to the layout reorganization.
62-62
: LGTM!The nested
Row
component inside theCol
component further improves the visual alignment of the quality report controls.
63-63
: LGTM!The nested
Col
component inside theRow
component further contributes to the layout reorganization.
64-66
: LGTM!The conditional rendering ensures that the
Button
component is only rendered iftaskReport?.id
is defined.
66-75
: LGTM!The added
Button
component with aDownloadOutlined
icon and a link provides a clear and accessible way to download the quality report.
76-76
: LGTM!The conditional rendering ensures that the
Button
component is only rendered iftaskReport?.id
is defined.
78-78
: LGTM!The nested
Row
component inside theCol
component further improves the visual alignment of the quality report controls.
80-80
: LGTM!The
Row
component with thejustify='end'
property ensures that the content is aligned to the end.
81-81
: LGTM!The nested
Col
component inside theRow
component further contributes to the layout reorganization.
82-84
: LGTM!The conditional rendering ensures that the timestamp is only rendered if
taskReport?.id
is defined.
84-86
: LGTM!The added
div
element with thecvat-analytics-time-hint
class displays the timestamp with the appropriate styling.
86-86
: LGTM!The
Text
component displays the formatted timestamp usingmoment
, improving readability.
87-87
: LGTM!The conditional rendering ensures that the timestamp is only rendered if
taskReport?.id
is defined.
92-92
: LGTM!The nested
Col
component inside theRow
component further contributes to the layout reorganization.
94-97
: LGTM!The
SettingOutlined
icon with a click handler provides an accessible way to toggle the quality settings visibility.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8106 +/- ##
========================================
Coverage 83.40% 83.40%
========================================
Files 389 389
Lines 41297 41297
Branches 3858 3858
========================================
Hits 34442 34442
Misses 6855 6855
|
@bsekachev |
Quality Gate passedIssues Measures |
Motivation and context
The timestamp looks incorrectly aligned + margin after the icon looks too big.
Before:
After:
How has this been tested?
Checklist
develop
branch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Bug Fixes
Style
Refactor
Row
andCol
components.