Release v2.16.0 #8169
Merged
Release v2.16.0 #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cvat-bot[bot]](https://avatars.githubusercontent.com/in/406724?s=60&v=4){kind=small}
Update develop after v2.15.0
…8100) <!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> - Fixed quality report computation in tasks with non-skeleton labels after skeleton labels ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> Unit tests ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [ ] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved quality computation for tasks with both skeletons and normal labels in the Computer Vision Annotation Tool (CVAT). - **Tests** - Added a new test to ensure quality can be computed correctly when a non-skeleton label follows a skeleton label. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Docker Scout found several vulnerabilities, updated or removed them
This PR introduces new page with information about data processing(status and progress). For now it will support: task creation, import/export. For previous discussions refer to: #7537 Co-authored-by: Maria Khrustaleva <maria@cvat.ai> Co-authored-by: Boris Sekachev <sekachev.bs@gmail.com>
<!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Added a timeout option to the `downloadExport` command to improve test stability and reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
… OSError: [Errno 116] Stale file handle error on NFS volumes (#8121) Due the nocleanup option defaults to false and we use AUTO-generated names for backend process log files, this causes NFS4ERR_STALE to appear on NFS-mounted volumes ```python Traceback (most recent call last): File "/usr/lib/python3/dist-packages/supervisor/loggers.py", line 109, in emit self.flush() File "/usr/lib/python3/dist-packages/supervisor/loggers.py", line 68, in flush self.stream.flush() OSError: [Errno 116] Stale file handle ``` http://supervisord.org/configuration.html#:~:text=Introduced%3A%203.0-,nocleanup,-Prevent%20supervisord%20from https://stackoverflow.com/questions/40262823/stale-file-handle-error-when-process-trying-read-the-file-that-other-process Co-authored-by: Roman Donchenko <roman@cvat.ai>
Currently, the views that use `LabeledDataSerializer` for input do something unconventional: they create the serializer with the input data, call `is_valid()`, but then use the original data instead of the `validated_data` member. I believe this is because `validated_data` in this case is unusable because of the `source` attributes on some of the fields in the nested serializers. For example, in `LabeledImageSerializer`, the `attributes` field has a source of `labeledimageattributeval_set`. This works well when serializing `LabeledImage` objects, but when you're deserializing, this creates a dict with a `labeledimageattributeval_set` key. Such objects are incompatible with functions like `patch_job_data`, which expect the `attributes` key instead. In the current code, using `data` instead of `validated_data` seems to work okay-ish. It _is_ a bit confusing, though, because it's unconventional. For example, the `default` values set in serializer fields are effectively useless, because they're only filled in `validated_data`. However, I'm currently working on a feature where a `LabeledDataSerializer` is incorporated into another serializer, and this problem means that I can't use `validated_data` for the parent serializer either, and that means I can't implement custom `to_internal_value` or `create` methods. So I'd much rather fix this. While we could do it by making `patch_job_data` and others accept `labeledimageattributeval_set`, this seems counterproductive. The name `attributes` is much easier to read & understand. So instead, change the models so that the attributes of an annotation object can be accessed via `.attributes` and the shapes of a track via `.tracks`. That way, the `source` attributes become unnecessary. This fixes the problem _and_ makes the code clearer at the same time.
<!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> The timestamp looks incorrectly aligned + margin after the icon looks too big. Before:  After:  ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - ~~[ ] I have updated the documentation accordingly~~ - ~~[ ] I have added tests to cover my changes~~ - ~~[ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~~ - ~~[ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))~~ ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Aligned the quality report button and timestamp on the quality page. - **Style** - Updated styling for buttons and quality settings switch on the analytics page. - **Refactor** - Reorganized the layout of the quality report controls for improved clarity and usability using Ant Design's `Row` and `Col` components. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
The smokescreen clone was being done with `--depth=1`, which broke as soon as the tip of the master branch advanced past the commit we wanted. Use `--filter=blob:none` instead, which still avoids fetching the full history, but allows us to check out any commit we want.
<!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> Follow up for #8144 - Added a seemingly missing migration ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [ ] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated database schema to improve relationship consistency within the application. No visible changes for end-users. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…to be decoded is not correctly encoded. (#8166)
<!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> Depends on #8162 ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> - Added recording and reporting of the last assignee update time on the server - Added reporting of the assignee in quality reports ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> Unit tests ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [ ] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added tracking for the last assignee update time across jobs, tasks, and projects. - Introduced assignee information in quality reports. - **Bug Fixes** - Ensured accurate handling of assignee details and update times in various entities. - **Tests** - Added extensive test coverage for creating and updating assignee details in jobs, tasks, projects, and quality reports. - **Documentation** - Updated schema to include the new `assignee_updated_date` field. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
cvat-bot
bot
requested review from
azhavoro,
zhiltsov-max,
bsekachev,
mdacoca,
SpecLad and
Marishka17
as code owners
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8169 +/- ##
==========================================
- Coverage 83.67% 83.40% -0.28%
==========================================
Files 383 388 +5
Lines 40502 41299 +797
Branches 3830 3852 +22
==========================================
+ Hits 33892 34445 +553
- Misses 6610 6854 +244
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Set of features to track background activities: importing/exporting datasets, annotations or backups, creating tasks. Now you may find these processes on Requests page, it allows a user to understand current status of these activities and enhances user experience, not losing progress when the browser tab is closed (Requests page #7537)
User now may update a job state from the corresponding task page (Extended client plugins system, refactored job finishing #8102)
The server will now record and report last assignee update time (Track last assignee update #8119)
Changed
"Finish the job" button on annotation view now only sets state to 'completed'. The job stage keeps unchanged (Extended client plugins system, refactored job finishing #8102)
Log files for individual backend processes are now stored in ephemeral storage of each backend container rather than in the
cvat_logsvolume (Fixed unexpected deletion of log files of other processes that led to OSError: [Errno 116] Stale file handle error on NFS volumes #8121)Do not reset opacity level each time frame switched if there are masks on the frame (Do not adjust opacity level each frame if there are masks #8149)
Removed
Fixed
A possible crash in quality computation for tasks with skeletons and normal labels (Fix quality computation for tasks with skeletons and normal labels #8100)
Quality report button and timestamp alignments on quality page (Fixed timestamp alignment on quality page #8106)
Fixed display of working time in Grafana management dashboard (Fixed display of working time in Grafana management dashboard #8112)
Fixed unexpected deletion of log files of other processes that led to OSError: [Errno 116] Stale file handle error on NFS volumes (Fixed unexpected deletion of log files of other processes that led to OSError: [Errno 116] Stale file handle error on NFS volumes #8121)
Attribute values with ":" may be displayed incorrectly on canvas (Fixed attributes update on cvat-canvas #8137)
Fixed broken server Docker image build (Fix the Docker image build #8160)
DOMException: Failed to execute 'atob' on 'Window': The string to be decoded is not correctly encoded (Fixed DOMException: Failed to execute 'atob' on 'Window': The string to be decoded is not correctly encoded. #8166)