-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Docker image build #8160
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Dockerfile (1 hunks)
Additional comments not posted (1)
Dockerfile (1)
88-88
: LGTM! Verify the functionality of the smokescreen build process.The
git clone
command has been updated to use the--filter=blob:none
option, which optimizes the cloning process by excluding file blobs. Ensure that this change does not affect the functionality of thesmokescreen
build process.
The smokescreen clone was being done with `--depth=1`, which broke as soon as the tip of the master branch advanced past the commit we wanted. Use `--filter=blob:none` instead, which still avoids fetching the full history, but allows us to check out any commit we want.
0909122
to
a008c55
Compare
Motivation and context
The smokescreen clone was being done with
--depth=1
, which broke as soon as the tip of the master branch advanced past the commit we wanted. Use--filter=blob:none
instead, which still avoids fetching the full history, but allows us to check out any commit we want.How has this been tested?
Checklist
develop
branch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
smokescreen
project by reducing the amount of data cloned from the repository.