Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Reset Handler tutorial #12

Conversation

ygoumaz
Copy link

@ygoumaz ygoumaz commented Jun 6, 2023

Internal review

Adding new tutorial on how to handle simulation reset through Webots interface.

Current tutorial is in the wiki: https://github.com/cyberbotics/webots_ros2/wiki/Tutorial-Webots-Simulation-Reset-with-ROS-2.

@ygoumaz ygoumaz added the enhancement New feature or request label Jun 6, 2023
@ygoumaz ygoumaz self-assigned this Jun 6, 2023
@ygoumaz ygoumaz requested a review from omichel June 7, 2023 08:59
@ygoumaz ygoumaz marked this pull request as ready for review June 7, 2023 08:59
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rephrased some sentences which were a bit unclear to me. Let me know if my understanding is correct or not.

ygoumaz and others added 7 commits June 7, 2023 14:12
…andler.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
…andler.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
…andler.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
…andler.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
@ygoumaz ygoumaz requested a review from omichel June 7, 2023 12:31
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks better to me this way.
Thank you.

@ygoumaz ygoumaz merged commit 90e9ea4 into enhancement-add-reset-handler-tutorial Jun 7, 2023
ygoumaz added a commit that referenced this pull request Jul 11, 2023
* Update launch files to declare WebotsController node (#11) (ros2#3763)

* change launch files

* Update Setting-Up-Simulation-Webots-Basic.rst

* update minimal version tutorial 2

* add upcoming versions

* New Reset Handler tutorial (#12) (ros2#3764)

* new tutorial

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update macOS-Development-Setup.rst (ros2#3758)

- add Xcode App Store link
    - BASH -> ZSH (default)
    - make homebrew paths generic

Co-authored-by: Philipp Dittmann <dittmann@cs.uni-bremen.de>

* Change confusing title between Debian package and Debian platform (ros2#3771)

Currently Debian does not offer ROS2 packages. Change the title that can
be confusing.

* Make the calendar more mobile-friendly. (ros2#3774)

* Make the calendar more mobile-friendly.

When looking at some of the analytics, it looks like this
page is particularly not mobile friendly.  That's because
the Google calendar embedded on the bottom of the page
is of fixed with 800x600, which doesn't work well on
many mobile devices.

What we do here is to see if a device has 767 or less pixels.
If it does, then we just show the agenda, which fits in just
280 pixels.  If we have more than that, we have room for
the full monthly agenda, so we show the full thing.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: PhDittmann <dittmann@tzi.de>
Co-authored-by: Philipp Dittmann <dittmann@cs.uni-bremen.de>
Co-authored-by: Quentin Quadrat <lecrapouille@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
ygoumaz added a commit that referenced this pull request Jul 11, 2023
* new tutorial

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants